Skip to content

Commit 3037b71

Browse files
committed
Revert some stuff
1 parent b168427 commit 3037b71

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

sentry-android-replay/src/main/java/io/sentry/android/replay/ReplayCache.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,6 @@ public class ReplayCache(
108108
frames += frame
109109
}
110110

111-
private var failed = false
112-
113111
/**
114112
* Creates a video out of currently stored [frames] given the start time and duration using the
115113
* on-device codecs [android.media.MediaCodec]. The generated video will be stored in
@@ -184,7 +182,7 @@ public class ReplayCache(
184182

185183
// we either encode a new frame within the step bounds or replicate the last known frame
186184
// to respect the video duration
187-
if (encode(lastFrame) /* && (segmentId != 1 || failed)*/) {
185+
if (encode(lastFrame)) {
188186
frameCount++
189187
} else if (lastFrame != null) {
190188
// if we failed to encode the frame, we delete the screenshot right away as the
@@ -196,7 +194,6 @@ public class ReplayCache(
196194
}
197195

198196
if (frameCount == 0) {
199-
failed = true
200197
options.logger.log(
201198
DEBUG,
202199
"Generated a video with no frames, not capturing a replay segment"

sentry/src/main/java/io/sentry/SentryEnvelopeItem.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ public static SentryEnvelopeItem fromReplay(
475475
if (cleanupReplayFolder) {
476476
FileUtils.deleteRecursively(replayVideo.getParentFile());
477477
} else {
478-
//replayVideo.delete();
478+
replayVideo.delete();
479479
}
480480
}
481481
}

0 commit comments

Comments
 (0)