ref(core): Reduce unnecessary boxing and redundant null checks (JAVA-554) (#5520)

* ref(core): Use static compare and drop redundant null checks

Replace boxed Long.valueOf(...).compareTo(...) with Long.compare(...),
which avoids the unnecessary boxing. Also remove the redundant != null
checks that precede an instanceof, since instanceof already returns
false for null.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* ref(core): Remove unnecessary boxing (JAVA-554)

Replace Integer.valueOf/Double.valueOf boxing with primitives or the
appropriate parse method. String.format takes the primitives directly,
the double conversions only need a cast, and the version check parses
straight to a primitive double via Double.parseDouble.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* changelog

* ref(core): Drop redundant StringBuilder in hashing helper (JAVA-554)

Return the hex string directly instead of wrapping it in a StringBuilder
only to immediately call toString().

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* ref(core): Use StandardCharsets.UTF_8 and tidy comments (JAVA-554)

Replace Charset.forName("UTF-8") with the StandardCharsets constant,
which avoids the lookup and cannot throw a checked exception. Also
collapse the leftover hashing comments into one.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: runningcode

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Improvements
 
 - Improve SDK init performance by replacing `java.net.URI` with custom string parsing for DSN ([#5448](https://github.com/getsentry/sentry-java/pull/5448))
+- Remove unnecessary boxing to improve performance ([#5520](https://github.com/getsentry/sentry-java/pull/5520))
 
 ### Fixes
 

sentry/src/main/java/io/sentry/CircularFifoQueue.java

@@ -258,8 +258,7 @@ public boolean add(final @NotNull E element) {
     if (index < 0 || index >= sz) {
       throw new NoSuchElementException(
           String.format(
-              "The specified index (%1$d) is outside the available range [0, %2$d)",
-              Integer.valueOf(index), Integer.valueOf(sz)));
+              "The specified index (%1$d) is outside the available range [0, %2$d)", index, sz));
     }
 
     final int idx = (start + index) % maxElements;

sentry/src/main/java/io/sentry/DateUtils.java

@@ -115,7 +115,7 @@ public static double nanosToMillis(final double nanos) {
    * @return date rounded down to milliseconds
    */
   public static Date nanosToDate(final long nanos) {
-    final Double millis = nanosToMillis(Double.valueOf(nanos));
+    final Double millis = nanosToMillis((double) nanos);
     return getDateTime(millis.longValue());
   }
 
@@ -137,7 +137,7 @@ public static Date nanosToDate(final long nanos) {
    * @return seconds
    */
   public static double nanosToSeconds(final long nanos) {
-    return Double.valueOf(nanos) / (1000.0 * 1000.0 * 1000.0);
+    return (double) nanos / (1000.0 * 1000.0 * 1000.0);
   }
 
   /**

sentry/src/main/java/io/sentry/ScopesStorageFactory.java

@@ -29,7 +29,7 @@ public final class ScopesStorageFactory {
           try {
             final @Nullable Object otelScopesStorage =
                 otelScopesStorageClazz.getDeclaredConstructor().newInstance();
-            if (otelScopesStorage != null && otelScopesStorage instanceof IScopesStorage) {
+            if (otelScopesStorage instanceof IScopesStorage) {
               return (IScopesStorage) otelScopesStorage;
             }
           } catch (InstantiationException e) {

sentry/src/main/java/io/sentry/SentryDate.java

@@ -47,6 +47,6 @@ public final boolean isAfter(final @NotNull SentryDate otherDate) {
 
   @Override
   public int compareTo(@NotNull SentryDate otherDate) {
-    return Long.valueOf(nanoTimestamp()).compareTo(otherDate.nanoTimestamp());
+    return Long.compare(nanoTimestamp(), otherDate.nanoTimestamp());
   }
 }

sentry/src/main/java/io/sentry/SentryNanotimeDate.java

@@ -46,7 +46,7 @@ public long nanoTimestamp() {
 
   @Override
   public long laterDateNanosTimestampByDiff(final @Nullable SentryDate otherDate) {
-    if (otherDate != null && otherDate instanceof SentryNanotimeDate) {
+    if (otherDate instanceof SentryNanotimeDate) {
       final @NotNull SentryNanotimeDate otherNanoDate = (SentryNanotimeDate) otherDate;
       if (compareTo(otherDate) < 0) {
         return nanotimeDiff(this, otherNanoDate);
@@ -66,9 +66,9 @@ public int compareTo(@NotNull SentryDate otherDate) {
       final long thisDateMillis = date.getTime();
       final long otherDateMillis = otherNanoDate.date.getTime();
       if (thisDateMillis == otherDateMillis) {
-        return Long.valueOf(nanos).compareTo(otherNanoDate.nanos);
+        return Long.compare(nanos, otherNanoDate.nanos);
       } else {
-        return Long.valueOf(thisDateMillis).compareTo(otherDateMillis);
+        return Long.compare(thisDateMillis, otherDateMillis);
       }
     } else {
       return super.compareTo(otherDate);

sentry/src/main/java/io/sentry/SpanFactoryFactory.java

@@ -21,7 +21,7 @@ public final class SpanFactoryFactory {
           try {
             final @Nullable Object otelSpanFactory =
                 otelSpanFactoryClazz.getDeclaredConstructor().newInstance();
-            if (otelSpanFactory != null && otelSpanFactory instanceof ISpanFactory) {
+            if (otelSpanFactory instanceof ISpanFactory) {
               return (ISpanFactory) otelSpanFactory;
             }
           } catch (InstantiationException e) {

sentry/src/main/java/io/sentry/internal/eventprocessor/EventProcessorAndOrder.java

@@ -29,6 +29,6 @@ public EventProcessorAndOrder(
 
   @Override
   public int compareTo(@NotNull EventProcessorAndOrder o) {
-    return order.compareTo(o.order);
+    return Long.compare(order, o.order);
   }
 }

sentry/src/main/java/io/sentry/protocol/Contexts.java

@@ -282,7 +282,7 @@ public void putAll(final @Nullable Contexts contexts) {
 
   @Override
   public boolean equals(final @Nullable Object obj) {
-    if (obj != null && obj instanceof Contexts) {
+    if (obj instanceof Contexts) {
       final @NotNull Contexts otherContexts = (Contexts) obj;
       return internalStorage.equals(otherContexts.internalStorage);
     }

sentry/src/main/java/io/sentry/util/LifecycleHelper.java

@@ -7,7 +7,7 @@
 public final class LifecycleHelper {
 
   public static void close(final @Nullable Object tokenObject) {
-    if (tokenObject != null && tokenObject instanceof ISentryLifecycleToken) {
+    if (tokenObject instanceof ISentryLifecycleToken) {
       final @NotNull ISentryLifecycleToken token = (ISentryLifecycleToken) tokenObject;
       token.close();
     }