Skip to content

Commit 423145d

Browse files
committed
clarify inApp vs nativeLibraryDir usage in code comment
1 parent 011008d commit 423145d

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

sentry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,9 @@ private SentryStackTrace createStackTrace(@NonNull final TombstoneProtos.Thread
117117
stackFrame.setFunction(frame.getFunctionName());
118118
stackFrame.setInstructionAddr(formatHex(frame.getPc()));
119119

120+
// inAppIncludes/inAppExcludes filter by Java/Kotlin package names, which don't overlap
121+
// with native C/C++ function names (e.g., "crash", "__libc_init"). For native frames,
122+
// isInApp() returns null, making nativeLibraryDir the effective in-app check.
120123
@Nullable
121124
Boolean inApp =
122125
SentryStackTraceFactory.isInApp(frame.getFunctionName(), inAppIncludes, inAppExcludes);

0 commit comments

Comments
 (0)