Fix User-Agent header to follow codebase conventions

runningcode · claude · runningcode · commit 455e8ee8fef3 · 2025-09-22T16:05:50.000+02:00
Replace custom fallback "sentry-android-distribution" with error throw when sentryClientName is null, following the pattern used throughout the codebase where sentryClientName is expected to always be set. Addresses PR review feedback about reusing consistent user agent. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/sentry-android-distribution/src/main/java/io/sentry/android/distribution/DistributionHttpClient.kt b/sentry-android-distribution/src/main/java/io/sentry/android/distribution/DistributionHttpClient.kt
@@ -81,7 +81,7 @@ internal class DistributionHttpClient(private val options: SentryOptions) {
       connection.setRequestProperty("Accept", "application/json")
       connection.setRequestProperty(
         "User-Agent",
-        options.sentryClientName ?: "sentry-android-distribution",
+        options.sentryClientName ?: throw IllegalStateException("sentryClientName must be set"),
       )
       connection.connectTimeout = options.connectionTimeoutMillis
       connection.readTimeout = options.readTimeoutMillis

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ internal class DistributionHttpClient(private val options: SentryOptions) {`
`81`	`81`	`connection.setRequestProperty("Accept", "application/json")`
`82`	`82`	`connection.setRequestProperty(`
`83`	`83`	`"User-Agent",`
`84`		`- options.sentryClientName ?: "sentry-android-distribution",`
	`84`	`+ options.sentryClientName ?: throw IllegalStateException("sentryClientName must be set"),`
`85`	`85`	`)`
`86`	`86`	`connection.connectTimeout = options.connectionTimeoutMillis`
`87`	`87`	`connection.readTimeout = options.readTimeoutMillis`