Skip to content

Commit 4563eae

Browse files
committed
Added case for timber logging both a message and a throwable
1 parent ed5f897 commit 4563eae

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class SentryTimberTree(
1515
private val scopes: IScopes,
1616
private val minEventLevel: SentryLevel,
1717
private val minBreadcrumbLevel: SentryLevel,
18-
private val minLogsLevel: SentryLogLevel = SentryLogLevel.INFO,
18+
private val minLogLevel: SentryLogLevel = SentryLogLevel.INFO,
1919
) : Timber.Tree() {
2020
private val pendingTag = ThreadLocal<String?>()
2121

@@ -243,9 +243,10 @@ public class SentryTimberTree(
243243
vararg args: Any?,
244244
) {
245245
// checks the log level
246-
if (isLoggable(sentryLogLevel, minLogsLevel)) {
246+
if (isLoggable(sentryLogLevel, minLogLevel)) {
247247
val throwableMsg = throwable?.message
248248
when {
249+
msg != null && throwableMsg != null -> scopes.logger().log(sentryLogLevel, "$msg\n$throwableMsg", *args)
249250
msg != null -> scopes.logger().log(sentryLogLevel, msg, *args)
250251
throwableMsg != null -> scopes.logger().log(sentryLogLevel, throwableMsg, *args)
251252
}

sentry-android-timber/src/test/java/io/sentry/android/timber/SentryTimberTreeTest.kt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,4 +302,12 @@ class SentryTimberTreeTest {
302302

303303
verify(fixture.logs).log(eq(SentryLogLevel.ERROR), eq("throwable message"))
304304
}
305+
306+
@Test
307+
fun `Tree logs throwable and message`() {
308+
val sut = fixture.getSut()
309+
sut.e(Throwable("throwable message"), "My message")
310+
311+
verify(fixture.logs).log(eq(SentryLogLevel.ERROR), eq("My message\nthrowable message"))
312+
}
305313
}

0 commit comments

Comments
 (0)