Move recycling to background

Author: markushi

sentry-android-replay/src/main/java/io/sentry/android/replay/ScreenshotRecorder.kt

@@ -142,10 +142,10 @@ internal class ScreenshotRecorder(
   }
 
   fun close() {
+    isCapturing.set(false)
     unbind(rootView?.get())
     rootView?.clear()
     screenshotStrategy.close()
-    isCapturing.set(false)
   }
 }
 

sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/CanvasStrategy.kt

@@ -189,14 +189,22 @@ internal class CanvasStrategy(
 
   override fun close() {
     isClosed.set(true)
-    screenshot?.let {
-      synchronized(it) {
-        if (!it.isRecycled) {
-          it.recycle()
-        }
-      }
-    }
-    screenshot = null
+    executor
+      .getExecutor()
+      .submit(
+        ReplayRunnable(
+          "CanvasStrategy.close",
+          {
+            screenshot?.let {
+              synchronized(it) {
+                if (!it.isRecycled) {
+                  it.recycle()
+                }
+              }
+            }
+          },
+        )
+      )
 
     // the image can be free, unprocessed or in transit
     freePictureRef.getAndSet(null)?.reader?.close()

sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/PixelCopyStrategy.kt

@@ -185,13 +185,21 @@ internal class PixelCopyStrategy(
 
   override fun close() {
     isClosed.set(true)
-    if (!screenshot.isRecycled) {
-      synchronized(screenshot) {
-        if (!screenshot.isRecycled) {
-          screenshot.recycle()
-        }
-      }
-    }
+    executor.submit(
+      ReplayRunnable(
+        "PixelCopyStrategy.close",
+        {
+          if (!screenshot.isRecycled) {
+            synchronized(screenshot) {
+              if (!screenshot.isRecycled) {
+                screenshot.recycle()
+              }
+            }
+          }
+        },
+      )
+    )
+
     if (!singlePixelBitmap.isRecycled) {
       singlePixelBitmap.recycle()
     }