Skip to content

Commit 4eced70

Browse files
authored
Merge branch 'main' into fix/reduce-noop-warnings-for-jul
2 parents a6c0e2a + 6c58c54 commit 4eced70

3 files changed

Lines changed: 5 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
- This should reduce the number of ANRs seen in `SentryGestureListener`
2929
- Do not use Sentry logging API in JUL if logs are disabled ([#4574](https://github.com/getsentry/sentry-java/pull/4574))
3030
- This was causing Sentry SDK to log warnings: "Sentry Log is disabled and this 'logger' call is a no-op."
31+
- Do not use Sentry logging API in Log4j2 if logs are disabled ([#4573](https://github.com/getsentry/sentry-java/pull/4573))
32+
- This was causing Sentry SDK to log warnings: "Sentry Log is disabled and this 'logger' call is a no-op."
3133

3234
## 8.17.0
3335

sentry-log4j2/src/main/java/io/sentry/log4j2/SentryAppender.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,8 @@ public void start() {
191191

192192
@Override
193193
public void append(final @NotNull LogEvent eventObject) {
194-
if (eventObject.getLevel().isMoreSpecificThan(minimumLevel)) {
194+
if (scopes.getOptions().getLogs().isEnabled()
195+
&& eventObject.getLevel().isMoreSpecificThan(minimumLevel)) {
195196
captureLog(eventObject);
196197
}
197198
if (eventObject.getLevel().isMoreSpecificThan(minimumEventLevel)) {
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
in-app-includes="io.sentry.samples"
22
logs.enabled=true
3+
debug=true

0 commit comments

Comments
 (0)