feat(replay): Track custom masking usage via fake integration

Author: markushi

sentry/src/main/java/io/sentry/SentryReplayOptions.java

@@ -1,5 +1,7 @@
 package io.sentry;
 
+import static io.sentry.util.IntegrationUtils.addIntegrationToSdkVersion;
+
 import io.sentry.protocol.SdkVersion;
 import io.sentry.util.SampleRateUtils;
 import java.util.ArrayList;
@@ -16,6 +18,8 @@
 
 public final class SentryReplayOptions {
 
+  private static final String CUSTOM_MASKING_INTEGRATION_NAME = "ReplayCustomMasking";
+
   public static final String TEXT_VIEW_CLASS_NAME = "android.widget.TextView";
   public static final String IMAGE_VIEW_CLASS_NAME = "android.widget.ImageView";
   public static final String WEB_VIEW_CLASS_NAME = "android.webkit.WebView";
@@ -209,8 +213,9 @@ public enum SentryReplayQuality {
 
   public SentryReplayOptions(final boolean empty, final @Nullable SdkVersion sdkVersion) {
     if (!empty) {
-      setMaskAllText(true);
-      setMaskAllImages(true);
+      // Add default mask classes directly without setting usingCustomMasking flag
+      maskViewClasses.add(TEXT_VIEW_CLASS_NAME);
+      maskViewClasses.add(IMAGE_VIEW_CLASS_NAME);
       maskViewClasses.add(WEB_VIEW_CLASS_NAME);
       maskViewClasses.add(VIDEO_VIEW_CLASS_NAME);
       maskViewClasses.add(ANDROIDX_MEDIA_VIEW_CLASS_NAME);
@@ -275,11 +280,12 @@ public void setSessionSampleRate(final @Nullable Double sessionSampleRate) {
    * <p>Default is enabled.
    */
   public void setMaskAllText(final boolean maskAllText) {
+    addIntegrationToSdkVersion(CUSTOM_MASKING_INTEGRATION_NAME);
     if (maskAllText) {
-      addMaskViewClass(TEXT_VIEW_CLASS_NAME);
+      maskViewClasses.add(TEXT_VIEW_CLASS_NAME);
       unmaskViewClasses.remove(TEXT_VIEW_CLASS_NAME);
     } else {
-      addUnmaskViewClass(TEXT_VIEW_CLASS_NAME);
+      unmaskViewClasses.add(TEXT_VIEW_CLASS_NAME);
       maskViewClasses.remove(TEXT_VIEW_CLASS_NAME);
     }
   }
@@ -293,11 +299,12 @@ public void setMaskAllText(final boolean maskAllText) {
    * <p>Default is enabled.
    */
   public void setMaskAllImages(final boolean maskAllImages) {
+    addIntegrationToSdkVersion(CUSTOM_MASKING_INTEGRATION_NAME);
     if (maskAllImages) {
-      addMaskViewClass(IMAGE_VIEW_CLASS_NAME);
+      maskViewClasses.add(IMAGE_VIEW_CLASS_NAME);
       unmaskViewClasses.remove(IMAGE_VIEW_CLASS_NAME);
     } else {
-      addUnmaskViewClass(IMAGE_VIEW_CLASS_NAME);
+      unmaskViewClasses.add(IMAGE_VIEW_CLASS_NAME);
       maskViewClasses.remove(IMAGE_VIEW_CLASS_NAME);
     }
   }
@@ -308,6 +315,7 @@ public Set<String> getMaskViewClasses() {
   }
 
   public void addMaskViewClass(final @NotNull String className) {
+    addIntegrationToSdkVersion(CUSTOM_MASKING_INTEGRATION_NAME);
     this.maskViewClasses.add(className);
   }
 
@@ -317,6 +325,7 @@ public Set<String> getUnmaskViewClasses() {
   }
 
   public void addUnmaskViewClass(final @NotNull String className) {
+    addIntegrationToSdkVersion(CUSTOM_MASKING_INTEGRATION_NAME);
     this.unmaskViewClasses.add(className);
   }
 
@@ -351,12 +360,14 @@ public long getSessionDuration() {
 
   @ApiStatus.Internal
   public void setMaskViewContainerClass(@NotNull String containerClass) {
-    addMaskViewClass(containerClass);
+    addIntegrationToSdkVersion(CUSTOM_MASKING_INTEGRATION_NAME);
+    maskViewClasses.add(containerClass);
     maskViewContainerClass = containerClass;
   }
 
   @ApiStatus.Internal
   public void setUnmaskViewContainerClass(@NotNull String containerClass) {
+    addIntegrationToSdkVersion(CUSTOM_MASKING_INTEGRATION_NAME);
     unmaskViewContainerClass = containerClass;
   }
 

sentry/src/test/java/io/sentry/SentryReplayOptionsTest.kt

@@ -1,10 +1,18 @@
 package io.sentry
 
+import kotlin.test.BeforeTest
 import kotlin.test.Test
 import kotlin.test.assertEquals
+import kotlin.test.assertFalse
 import kotlin.test.assertTrue
 
 class SentryReplayOptionsTest {
+
+  @BeforeTest
+  fun setup() {
+    SentryIntegrationPackageStorage.getInstance().clearStorage()
+  }
+
   @Test
   fun `uses medium quality as default`() {
     val replayOptions = SentryReplayOptions(true, null)
@@ -126,4 +134,66 @@ class SentryReplayOptionsTest {
     assertTrue(headers.contains("X-Response-Header"))
     assertTrue(headers.contains("X-Debug-Header"))
   }
+
+  // Custom Masking Integration Tests
+
+  private fun hasCustomMaskingIntegration(): Boolean {
+    return SentryIntegrationPackageStorage.getInstance()
+      .integrations
+      .contains("ReplayCustomMasking")
+  }
+
+  @Test
+  fun `default options does not add ReplayCustomMasking integration`() {
+    SentryReplayOptions(false, null)
+    assertFalse(hasCustomMaskingIntegration())
+  }
+
+  @Test
+  fun `empty options does not add ReplayCustomMasking integration`() {
+    SentryReplayOptions(true, null)
+    assertFalse(hasCustomMaskingIntegration())
+  }
+
+  @Test
+  fun `addUnmaskViewClass adds ReplayCustomMasking integration`() {
+    val options = SentryReplayOptions(false, null)
+    options.addUnmaskViewClass("com.example.MyTextView")
+    assertTrue(hasCustomMaskingIntegration())
+  }
+
+  @Test
+  fun `setMaskViewContainerClass adds ReplayCustomMasking integration`() {
+    val options = SentryReplayOptions(false, null)
+    options.setMaskViewContainerClass("com.example.MyContainer")
+    assertTrue(hasCustomMaskingIntegration())
+  }
+
+  @Test
+  fun `setUnmaskViewContainerClass adds ReplayCustomMasking integration`() {
+    val options = SentryReplayOptions(false, null)
+    options.setUnmaskViewContainerClass("com.example.MyContainer")
+    assertTrue(hasCustomMaskingIntegration())
+  }
+
+  @Test
+  fun `addMaskViewClass adds ReplayCustomMasking integration`() {
+    val options = SentryReplayOptions(false, null)
+    options.addMaskViewClass("com.example.MySensitiveView")
+    assertTrue(hasCustomMaskingIntegration())
+  }
+
+  @Test
+  fun `setMaskAllText adds ReplayCustomMasking integration`() {
+    val options = SentryReplayOptions(false, null)
+    options.setMaskAllText(false)
+    assertTrue(hasCustomMaskingIntegration())
+  }
+
+  @Test
+  fun `setMaskAllImages adds ReplayCustomMasking integration`() {
+    val options = SentryReplayOptions(false, null)
+    options.setMaskAllImages(false)
+    assertTrue(hasCustomMaskingIntegration())
+  }
 }