Skip to content

Commit 50a7d51

Browse files
committed
Address PR comments
1 parent d5a0835 commit 50a7d51

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

sentry/src/main/java/io/sentry/SentryReplayOptions.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,11 +281,11 @@ public void setSessionSampleRate(final @Nullable Double sessionSampleRate) {
281281
* <p>Default is enabled.
282282
*/
283283
public void setMaskAllText(final boolean maskAllText) {
284-
trackCustomMasking();
285284
if (maskAllText) {
286285
maskViewClasses.add(TEXT_VIEW_CLASS_NAME);
287286
unmaskViewClasses.remove(TEXT_VIEW_CLASS_NAME);
288287
} else {
288+
trackCustomMasking();
289289
unmaskViewClasses.add(TEXT_VIEW_CLASS_NAME);
290290
maskViewClasses.remove(TEXT_VIEW_CLASS_NAME);
291291
}
@@ -300,11 +300,11 @@ public void setMaskAllText(final boolean maskAllText) {
300300
* <p>Default is enabled.
301301
*/
302302
public void setMaskAllImages(final boolean maskAllImages) {
303-
trackCustomMasking();
304303
if (maskAllImages) {
305304
maskViewClasses.add(IMAGE_VIEW_CLASS_NAME);
306305
unmaskViewClasses.remove(IMAGE_VIEW_CLASS_NAME);
307306
} else {
307+
trackCustomMasking();
308308
unmaskViewClasses.add(IMAGE_VIEW_CLASS_NAME);
309309
maskViewClasses.remove(IMAGE_VIEW_CLASS_NAME);
310310
}

sentry/src/test/java/io/sentry/SentryReplayOptionsTest.kt

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,10 +177,18 @@ class SentryReplayOptionsTest {
177177
}
178178

179179
@Test
180-
fun `trackCustomMasking only adds integration once`() {
180+
fun `setMaskAllText true does not set custom integration`() {
181181
val options = SentryReplayOptions(false, null)
182182
options.setMaskAllText(true)
183183
options.setMaskAllImages(true)
184+
assertFalse(hasCustomMaskingIntegration())
185+
}
186+
187+
@Test
188+
fun `trackCustomMasking only adds integration once`() {
189+
val options = SentryReplayOptions(false, null)
190+
options.setMaskAllText(false)
191+
options.setMaskAllImages(false)
184192
assertTrue(hasCustomMaskingIntegration())
185193
assertEquals(
186194
1,
@@ -189,7 +197,6 @@ class SentryReplayOptionsTest {
189197
},
190198
)
191199
}
192-
193200
@Test
194201
fun `addMaskViewClass adds ReplayCustomMasking integration`() {
195202
val options = SentryReplayOptions(false, null)

0 commit comments

Comments
 (0)