Merge branch 'main' into lcian/feat/report-build-tool

Author: lcian

CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## Unreleased
+## 8.16.1-alpha.2
 
 ### Features
 
@@ -10,6 +10,7 @@
 
 - Optimize scope when maxBreadcrumb is 0 ([#4504](https://github.com/getsentry/sentry-java/pull/4504))
 - Fix javadoc on TransportResult ([#4528](https://github.com/getsentry/sentry-java/pull/4528))
+- Session Replay: Fix `IllegalArgumentException` when `Bitmap` is initialized with non-positive values ([#4536](https://github.com/getsentry/sentry-java/pull/4536))
 - Set thread information on transaction from OpenTelemetry attributes ([#4478](https://github.com/getsentry/sentry-java/pull/4478))
 
 ### Internal

gradle.properties

@@ -11,7 +11,7 @@ org.jetbrains.dokka.experimental.gradle.pluginMode=V2Enabled
 android.useAndroidX=true
 
 # Release information
-versionName=8.16.0
+versionName=8.16.1-alpha.2
 
 # Override the SDK name on native crashes on Android
 sentryAndroidSdkName=sentry.native.android

sentry-android-replay/src/main/java/io/sentry/android/replay/util/Views.kt

@@ -245,4 +245,4 @@ internal fun View?.removeOnPreDrawListenerSafe(listener: ViewTreeObserver.OnPreD
   }
 }
 
-internal fun View.hasSize(): Boolean = width != 0 && height != 0
+internal fun View.hasSize(): Boolean = width > 0 && height > 0

sentry-android-replay/src/test/java/io/sentry/android/replay/util/ViewsTest.kt

@@ -0,0 +1,36 @@
+package io.sentry.android.replay.util
+
+import android.view.View
+import androidx.test.core.app.ApplicationProvider
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import kotlin.test.Test
+import kotlin.test.assertFalse
+import kotlin.test.assertTrue
+import org.junit.runner.RunWith
+
+@RunWith(AndroidJUnit4::class)
+class ViewsTest {
+  @Test
+  fun `hasSize returns true for positive values`() {
+    val view = View(ApplicationProvider.getApplicationContext())
+    view.right = 100
+    view.bottom = 100
+    assertTrue(view.hasSize())
+  }
+
+  @Test
+  fun `hasSize returns false for null values`() {
+    val view = View(ApplicationProvider.getApplicationContext())
+    view.right = 0
+    view.bottom = 0
+    assertFalse(view.hasSize())
+  }
+
+  @Test
+  fun `hasSize returns false for negative values`() {
+    val view = View(ApplicationProvider.getApplicationContext())
+    view.right = -1
+    view.bottom = -1
+    assertFalse(view.hasSize())
+  }
+}