exceptions log message instead of stacktraces

Author: stefanosiano

sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java

@@ -57,15 +57,11 @@ private static void addAsLog(
     if (!scopes.getOptions().getLogs().isEnabled()) {
       return;
     }
-    if (tr == null) {
+    final @Nullable String trMessage = tr != null ? tr.getMessage() : null;
+    if (tr == null || trMessage == null) {
       scopes.logger().log(level, msg);
     } else {
-      StringWriter sw = new StringWriter(256);
-      PrintWriter pw = new PrintWriter(sw, false);
-      tr.printStackTrace(pw);
-      pw.flush();
-      scopes.logger().log(level, msg != null ? (msg + "\n" + sw.toString()) : sw.toString());
-      pw.close();
+      scopes.logger().log(level, msg != null ? (msg + "\n" + trMessage) : trMessage);
     }
   }
 

sentry-android-core/src/test/java/io/sentry/android/core/SentryLogcatAdapterTest.kt

@@ -113,7 +113,7 @@ class SentryLogcatAdapterTest {
     fixture.breadcrumbs.first().assert(tag, "$commonMsg error exception", SentryLevel.ERROR)
     fixture.logs
       .first()
-      .assert("$commonMsg error exception\n${throwable.stackTraceToString()}", SentryLogLevel.ERROR)
+      .assert("$commonMsg error exception\n${throwable.message}", SentryLogLevel.ERROR)
   }
 
   @Test
@@ -124,7 +124,7 @@ class SentryLogcatAdapterTest {
     fixture.logs
       .first()
       .assert(
-        "$commonMsg verbose exception\n${throwable.stackTraceToString()}",
+        "$commonMsg verbose exception\n${throwable.message}",
         SentryLogLevel.TRACE,
       )
   }
@@ -136,7 +136,7 @@ class SentryLogcatAdapterTest {
     fixture.breadcrumbs.first().assert(tag, "$commonMsg info exception", SentryLevel.INFO)
     fixture.logs
       .first()
-      .assert("$commonMsg info exception\n${throwable.stackTraceToString()}", SentryLogLevel.INFO)
+      .assert("$commonMsg info exception\n${throwable.message}", SentryLogLevel.INFO)
   }
 
   @Test
@@ -146,7 +146,7 @@ class SentryLogcatAdapterTest {
     fixture.breadcrumbs.first().assert(tag, "$commonMsg debug exception", SentryLevel.DEBUG)
     fixture.logs
       .first()
-      .assert("$commonMsg debug exception\n${throwable.stackTraceToString()}", SentryLogLevel.DEBUG)
+      .assert("$commonMsg debug exception\n${throwable.message}", SentryLogLevel.DEBUG)
   }
 
   @Test
@@ -157,7 +157,7 @@ class SentryLogcatAdapterTest {
     fixture.logs
       .first()
       .assert(
-        "$commonMsg warning exception\n${throwable.stackTraceToString()}",
+        "$commonMsg warning exception\n${throwable.message}",
         SentryLogLevel.WARN,
       )
   }
@@ -169,7 +169,7 @@ class SentryLogcatAdapterTest {
     fixture.breadcrumbs.first().assert(tag, "$commonMsg wtf exception", SentryLevel.ERROR)
     fixture.logs
       .first()
-      .assert("$commonMsg wtf exception\n${throwable.stackTraceToString()}", SentryLogLevel.FATAL)
+      .assert("$commonMsg wtf exception\n${throwable.message}", SentryLogLevel.FATAL)
   }
 
   @Test