Wrap onDiscard callback in a try-catch and fix docstring

Author: alexander-alderman-webb

sentry/src/main/java/io/sentry/SentryOptions.java

@@ -179,7 +179,7 @@ public class SentryOptions {
    */
   private @Nullable BeforeBreadcrumbCallback beforeBreadcrumb;
 
-  /** Invoked when some payload sent from the SDK is dropped before consumed by Sentry, */
+  /** Invoked when some data from the SDK is dropped before being consumed by Sentry */
   private @Nullable OnDiscardCallback onDiscard;
 
   /** The cache dir. path for caching offline events */

sentry/src/main/java/io/sentry/clientreport/ClientReportRecorder.java

@@ -125,7 +125,16 @@ private void recordLostEventInternal(
     final ClientReportKey key = new ClientReportKey(reason, category);
     storage.addCount(key, countToAdd);
     if (options.getOnDiscard() != null) {
-      options.getOnDiscard().execute(reason, category, countToAdd);
+      try {
+        options.getOnDiscard().execute(reason, category, countToAdd);
+      } catch (Throwable e) {
+        options
+            .getLogger()
+            .log(
+                SentryLevel.ERROR,
+                "The onDiscard callback threw an exception. It will be added as breadcrumb and continue.",
+                e);
+      }
     }
   }