added exception thrown tests

Author: stefanosiano

CHANGELOG.md

@@ -32,7 +32,6 @@
 
 ### Fixes
 
-- Avoid StrictMode warnings (followup) ([#4809](https://github.com/getsentry/sentry-java/pull/4809))
 - Avoid StrictMode warnings ([#4724](https://github.com/getsentry/sentry-java/pull/4724))
 - Use logger from options for JVM profiler ([#4771](https://github.com/getsentry/sentry-java/pull/4771))
 - Session Replay: Avoid deadlock when pausing replay if no connection ([#4788](https://github.com/getsentry/sentry-java/pull/4788))

sentry-android-core/src/test/java/io/sentry/android/core/internal/util/AndroidRuntimeManagerTest.kt

@@ -57,6 +57,7 @@ class AndroidRuntimeManagerTest {
   @Test
   fun `runWithRelaxedPolicy changes policy and restores it afterwards even if the code throws`() {
     var called = false
+    var exceptionPropagated = false
     val threadPolicy = StrictMode.ThreadPolicy.Builder().detectAll().penaltyDeath().build()
     val vmPolicy = StrictMode.VmPolicy.Builder().detectAll().penaltyDeath().build()
 
@@ -75,19 +76,25 @@ class AndroidRuntimeManagerTest {
         called = true
         throw Exception("Test exception")
       }
-    } catch (_: Exception) {}
+    } catch (e: Exception) {
+      assertEquals(e.message, "Test exception")
+      exceptionPropagated = true
+    }
 
     // Policies should be reverted back
     assertEquals(threadPolicy.toString(), StrictMode.getThreadPolicy().toString())
     assertEquals(vmPolicy.toString(), StrictMode.getVmPolicy().toString())
 
     // Ensure the code ran
     assertTrue(called)
+    // Ensure the exception was propagated
+    assertTrue(exceptionPropagated)
   }
 
   @Test
   fun `runWithRelaxedPolicy with Runnable changes policy when running and restores it afterwards even if the code throws`() {
     var called = false
+    var exceptionPropagated = false
     val threadPolicy = StrictMode.ThreadPolicy.Builder().detectAll().penaltyDeath().build()
     val vmPolicy = StrictMode.VmPolicy.Builder().detectAll().penaltyDeath().build()
 
@@ -106,13 +113,18 @@ class AndroidRuntimeManagerTest {
         called = true
         throw Exception("Test exception")
       }
-    } catch (_: Exception) {}
+    } catch (e: Exception) {
+      assertEquals(e.message, "Test exception")
+      exceptionPropagated = true
+    }
 
     // Policies should be reverted back
     assertEquals(threadPolicy.toString(), StrictMode.getThreadPolicy().toString())
     assertEquals(vmPolicy.toString(), StrictMode.getVmPolicy().toString())
 
     // Ensure the code ran
     assertTrue(called)
+    // Ensure the exception was propagated
+    assertTrue(exceptionPropagated)
   }
 }

sentry/src/test/java/io/sentry/util/runtime/NeutralRuntimeManagerTest.kt

@@ -1,6 +1,8 @@
 package io.sentry.util.runtime
 
+import java.io.IOException
 import kotlin.test.Test
+import kotlin.test.assertEquals
 import kotlin.test.assertTrue
 
 class NeutralRuntimeManagerTest {
@@ -26,4 +28,38 @@ class NeutralRuntimeManagerTest {
     // Ensure the code ran
     assertTrue(called)
   }
+
+  @Test
+  fun `runWithRelaxedPolicy propagates exception`() {
+    var exceptionPropagated = false
+
+    try {
+      sut.runWithRelaxedPolicy<Unit> {
+        throw IOException("test")
+      }
+    } catch (e: IOException) {
+      assertEquals("test", e.message)
+      exceptionPropagated = true
+    }
+
+    // Ensure the exception was propagated
+    assertTrue(exceptionPropagated)
+  }
+
+  @Test
+  fun `runWithRelaxedPolicy with runnable propagates exception`() {
+    var exceptionPropagated = false
+
+    try {
+      sut.runWithRelaxedPolicy {
+        throw IOException("test")
+      }
+    } catch (e: IOException) {
+      assertEquals("test", e.message)
+      exceptionPropagated = true
+    }
+
+    // Ensure the exception was propagated
+    assertTrue(exceptionPropagated)
+  }
 }