Skip to content

Commit 82bc35e

Browse files
adinauerclaude
andcommitted
ref(jcache): Merge startSpanForKeys into startSpan overload
Replace the separate startSpanForKeys helper with a startSpan(Set, String) overload, unifying the two span creation methods under the same name. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 0a32614 commit 82bc35e

File tree

4 files changed

+19
-32
lines changed

4 files changed

+19
-32
lines changed

sentry-jcache/src/main/java/io/sentry/jcache/SentryJCacheWrapper.java

Lines changed: 16 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import io.sentry.SpanStatus;
99
import java.util.Arrays;
1010
import java.util.Iterator;
11+
import java.util.List;
1112
import java.util.Map;
1213
import java.util.Set;
1314
import java.util.stream.Collectors;
@@ -454,32 +455,22 @@ public Iterator<Entry<K, V>> iterator() {
454455

455456
private @Nullable ISpan startSpan(
456457
final @Nullable Object key, final @NotNull String operationName) {
457-
if (!scopes.getOptions().isEnableCacheTracing()) {
458-
return null;
459-
}
460-
461-
final ISpan activeSpan = scopes.getSpan();
462-
if (activeSpan == null || activeSpan.isNoOp()) {
463-
return null;
464-
}
465-
466-
final SpanOptions spanOptions = new SpanOptions();
467-
spanOptions.setOrigin(TRACE_ORIGIN);
468458
final String keyString = key != null ? String.valueOf(key) : null;
469-
final ISpan span =
470-
activeSpan.startChild("cache." + operationName, keyString, spanOptions);
471-
if (span.isNoOp()) {
472-
return null;
473-
}
474-
if (keyString != null) {
475-
span.setData(SpanDataConvention.CACHE_KEY_KEY, Arrays.asList(keyString));
476-
}
477-
span.setData(OPERATION_ATTRIBUTE, operationName);
478-
return span;
459+
return startSpan(operationName, keyString, keyString != null ? Arrays.asList(keyString) : null);
479460
}
480461

481462
private @Nullable ISpan startSpanForKeys(
482463
final @NotNull Set<?> keys, final @NotNull String operationName) {
464+
return startSpan(
465+
operationName,
466+
delegate.getName(),
467+
keys.stream().map(String::valueOf).collect(Collectors.toList()));
468+
}
469+
470+
private @Nullable ISpan startSpan(
471+
final @NotNull String operationName,
472+
final @Nullable String description,
473+
final @Nullable List<String> cacheKeys) {
483474
if (!scopes.getOptions().isEnableCacheTracing()) {
484475
return null;
485476
}
@@ -491,14 +482,13 @@ public Iterator<Entry<K, V>> iterator() {
491482

492483
final SpanOptions spanOptions = new SpanOptions();
493484
spanOptions.setOrigin(TRACE_ORIGIN);
494-
final ISpan span =
495-
activeSpan.startChild("cache." + operationName, delegate.getName(), spanOptions);
485+
final ISpan span = activeSpan.startChild("cache." + operationName, description, spanOptions);
496486
if (span.isNoOp()) {
497487
return null;
498488
}
499-
span.setData(
500-
SpanDataConvention.CACHE_KEY_KEY,
501-
keys.stream().map(String::valueOf).collect(Collectors.toList()));
489+
if (cacheKeys != null) {
490+
span.setData(SpanDataConvention.CACHE_KEY_KEY, cacheKeys);
491+
}
502492
span.setData(OPERATION_ATTRIBUTE, operationName);
503493
return span;
504494
}

sentry-spring-7/src/main/java/io/sentry/spring7/cache/SentryCacheWrapper.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,7 @@ public boolean invalidate() {
307307
final SpanOptions spanOptions = new SpanOptions();
308308
spanOptions.setOrigin(TRACE_ORIGIN);
309309
final String keyString = key != null ? String.valueOf(key) : null;
310-
final ISpan span =
311-
activeSpan.startChild("cache." + operationName, keyString, spanOptions);
310+
final ISpan span = activeSpan.startChild("cache." + operationName, keyString, spanOptions);
312311
if (span.isNoOp()) {
313312
return null;
314313
}

sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/cache/SentryCacheWrapper.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,7 @@ public boolean invalidate() {
307307
final SpanOptions spanOptions = new SpanOptions();
308308
spanOptions.setOrigin(TRACE_ORIGIN);
309309
final String keyString = key != null ? String.valueOf(key) : null;
310-
final ISpan span =
311-
activeSpan.startChild("cache." + operationName, keyString, spanOptions);
310+
final ISpan span = activeSpan.startChild("cache." + operationName, keyString, spanOptions);
312311
if (span.isNoOp()) {
313312
return null;
314313
}

sentry-spring/src/main/java/io/sentry/spring/cache/SentryCacheWrapper.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,7 @@ public boolean invalidate() {
235235
final SpanOptions spanOptions = new SpanOptions();
236236
spanOptions.setOrigin(TRACE_ORIGIN);
237237
final String keyString = key != null ? String.valueOf(key) : null;
238-
final ISpan span =
239-
activeSpan.startChild("cache." + operationName, keyString, spanOptions);
238+
final ISpan span = activeSpan.startChild("cache." + operationName, keyString, spanOptions);
240239
if (span.isNoOp()) {
241240
return null;
242241
}

0 commit comments

Comments
 (0)