File tree Expand file tree Collapse file tree 1 file changed +6
-0
lines changed
sentry-async-profiler/src/main/java/io/sentry/asyncprofiler/profiling Expand file tree Collapse file tree 1 file changed +6
-0
lines changed Original file line number Diff line number Diff line change @@ -273,6 +273,12 @@ private void stop(final boolean restartProfiler) {
273273 // the data in a list and send it when the next chunk is finished.
274274 try (final @ NotNull ISentryLifecycleToken ignored2 = payloadLock .acquire ()) {
275275 File jfrFile = new File (filename );
276+ // TODO: should we add deleteOnExit() here to let the JVM clean up the file?
277+ // as in `Sentry.java` `initJvmContinuousProfiling` each time we start the profiler we
278+ // create a new
279+ // temp directory/file that we can't cleanup on restart. Unless the user sets
280+ // `profiling-traces-dir-path` manually
281+ // jfrFile.deleteOnExit();
276282 payloadBuilders .add (
277283 new ProfileChunk .Builder (
278284 profilerId ,
You can’t perform that action at this time.
0 commit comments