Skip to content

Commit 9a94762

Browse files
committed
Add missing version to header value
1 parent 320eed7 commit 9a94762

File tree

3 files changed

+25
-15
lines changed

3 files changed

+25
-15
lines changed

sentry/src/main/java/io/sentry/W3CTraceparentHeader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ public W3CTraceparentHeader(
2727

2828
public @NotNull String getValue() {
2929
final String sampledFlag = sampled != null && sampled ? "01" : "00";
30-
return String.format("%s-%s-%s", traceId, spanId, sampledFlag);
30+
return String.format("00-%s-%s-%s", traceId, spanId, sampledFlag);
3131
}
3232
}

sentry/src/test/java/io/sentry/W3CTraceparentHeaderTest.kt

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class W3CTraceparentHeaderTest {
1313
val header = W3CTraceparentHeader(traceId, spanId, true)
1414

1515
assertEquals("traceparent", header.name)
16-
assertEquals("12345678123456781234567812345678-1234567812345678-01", header.value)
16+
assertEquals("00-12345678123456781234567812345678-1234567812345678-01", header.value)
1717
}
1818

1919
@Test
@@ -23,7 +23,7 @@ class W3CTraceparentHeaderTest {
2323
val header = W3CTraceparentHeader(traceId, spanId, false)
2424

2525
assertEquals("traceparent", header.name)
26-
assertEquals("12345678123456781234567812345678-1234567812345678-00", header.value)
26+
assertEquals("00-12345678123456781234567812345678-1234567812345678-00", header.value)
2727
}
2828

2929
@Test
@@ -33,7 +33,7 @@ class W3CTraceparentHeaderTest {
3333
val header = W3CTraceparentHeader(traceId, spanId, null)
3434

3535
assertEquals("traceparent", header.name)
36-
assertEquals("12345678123456781234567812345678-1234567812345678-00", header.value)
36+
assertEquals("00-12345678123456781234567812345678-1234567812345678-00", header.value)
3737
}
3838

3939
@Test
@@ -45,9 +45,10 @@ class W3CTraceparentHeaderTest {
4545
val value = header.value
4646
val parts = value.split("-")
4747

48-
assertEquals(3, parts.size)
49-
assertEquals("abcdefabcdefabcdabcdefabcdefabcd", parts[0]) // Trace ID (32 chars)
50-
assertEquals("abcdefabcdefabcd", parts[1]) // Span ID (16 chars)
51-
assertEquals("01", parts[2]) // Sampled flag (2 chars)
48+
assertEquals(4, parts.size)
49+
assertEquals("00", parts[0]) // Version
50+
assertEquals("abcdefabcdefabcdabcdefabcdefabcd", parts[1]) // Trace ID (32 hex chars)
51+
assertEquals("abcdefabcdefabcd", parts[2]) // Span ID (16 hex chars)
52+
assertEquals("01", parts[3]) // Sampled flag
5253
}
5354
}

sentry/src/test/java/io/sentry/util/TracingUtilsTest.kt

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -471,10 +471,14 @@ class TracingUtilsTest {
471471
assertEquals("traceparent", tracingHeaders.w3cTraceparentHeader!!.name)
472472

473473
val headerValue = tracingHeaders.w3cTraceparentHeader!!.value
474-
475-
assertTrue(headerValue.contains(fixture.span.spanContext.traceId.toString()))
476-
assertTrue(headerValue.contains(fixture.span.spanContext.spanId.toString()))
477-
assertTrue(headerValue.endsWith("-01"))
474+
assertTrue(headerValue.startsWith("00-"))
475+
476+
val parts = headerValue.split("-")
477+
assertEquals(4, parts.size)
478+
assertEquals("00", parts[0])
479+
assertEquals(fixture.span.spanContext.traceId.toString(), parts[1])
480+
assertEquals(fixture.span.spanContext.spanId.toString(), parts[2])
481+
assertEquals("01", parts[3])
478482
}
479483

480484
@Test
@@ -493,8 +497,13 @@ class TracingUtilsTest {
493497
assertEquals("traceparent", w3cTrace.name)
494498

495499
val headerValue = w3cTrace.value
496-
assertTrue(headerValue.contains(fixture.scope.propagationContext.traceId.toString()))
497-
assertTrue(headerValue.contains(fixture.scope.propagationContext.spanId.toString()))
498-
assertTrue(headerValue.endsWith("-00"))
500+
assertTrue(headerValue.startsWith("00-"))
501+
502+
val parts = headerValue.split("-")
503+
assertEquals(4, parts.size)
504+
assertEquals("00", parts[0])
505+
assertEquals(fixture.scope.propagationContext.traceId.toString(), parts[1])
506+
assertEquals(fixture.scope.propagationContext.spanId.toString(), parts[2])
507+
assertEquals("00", parts[3])
499508
}
500509
}

0 commit comments

Comments
 (0)