Merge pull request #5315 from getsentry/ref/queue-instrumentation-kafka-log-failures

ref(kafka): [Queue Instrumentation 20] Log Kafka instrumentation failures

Author: adinauer

sentry-kafka/src/main/java/io/sentry/kafka/SentryKafkaConsumerTracing.java

@@ -6,6 +6,7 @@
 import io.sentry.ISentryLifecycleToken;
 import io.sentry.ITransaction;
 import io.sentry.ScopesAdapter;
+import io.sentry.SentryLevel;
 import io.sentry.SentryTraceHeader;
 import io.sentry.SpanDataConvention;
 import io.sentry.SpanStatus;
@@ -83,7 +84,11 @@ <K, V, U> U withTracingImpl(
     try {
       forkedScopes = scopes.forkedRootScopes(CREATOR);
       lifecycleToken = forkedScopes.makeCurrent();
-    } catch (Throwable ignored) {
+    } catch (Throwable t) {
+      scopes
+          .getOptions()
+          .getLogger()
+          .log(SentryLevel.ERROR, "Failed to fork scopes for Kafka consumer tracing.", t);
       return callable.call();
     }
 
@@ -175,7 +180,11 @@ private boolean isIgnored() {
       }
 
       return transaction;
-    } catch (Throwable ignored) {
+    } catch (Throwable t) {
+      scopes
+          .getOptions()
+          .getLogger()
+          .log(SentryLevel.ERROR, "Failed to start Kafka consumer tracing transaction.", t);
       return null;
     }
   }
@@ -194,8 +203,12 @@ private void finishTransaction(
         transaction.setThrowable(throwable);
       }
       transaction.finish();
-    } catch (Throwable ignored) {
+    } catch (Throwable t) {
       // Instrumentation must never break customer processing.
+      scopes
+          .getOptions()
+          .getLogger()
+          .log(SentryLevel.ERROR, "Failed to finish Kafka consumer tracing transaction.", t);
     }
   }
 

sentry-kafka/src/main/java/io/sentry/kafka/SentryKafkaProducerInterceptor.java

@@ -5,6 +5,7 @@
 import io.sentry.IScopes;
 import io.sentry.ISpan;
 import io.sentry.ScopesAdapter;
+import io.sentry.SentryLevel;
 import io.sentry.SentryTraceHeader;
 import io.sentry.SpanDataConvention;
 import io.sentry.SpanOptions;
@@ -71,8 +72,11 @@ public SentryKafkaProducerInterceptor(
 
       span.setStatus(SpanStatus.OK);
       span.finish();
-    } catch (Throwable ignored) {
-      // Instrumentation must never break the customer's Kafka send.
+    } catch (Throwable t) {
+      scopes
+          .getOptions()
+          .getLogger()
+          .log(SentryLevel.ERROR, "Failed to instrument Kafka producer record.", t);
     }
 
     return record;