updated changelog

added test

Author: stefanosiano

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Fixes
 
+- Optimize scope when maxBreadcrumb is 0 ([#4504](https://github.com/getsentry/sentry-java/pull/4504))
 - No longer send out empty log envelopes ([#4497](https://github.com/getsentry/sentry-java/pull/4497))
 
 ### Dependencies

sentry/src/test/java/io/sentry/ScopeTest.kt

@@ -1,6 +1,7 @@
 package io.sentry
 
 import io.sentry.SentryLevel.WARNING
+import io.sentry.protocol.Contexts
 import io.sentry.protocol.Request
 import io.sentry.protocol.SentryId
 import io.sentry.protocol.User
@@ -13,6 +14,7 @@ import org.mockito.kotlin.mock
 import org.mockito.kotlin.never
 import org.mockito.kotlin.times
 import org.mockito.kotlin.verify
+import org.mockito.kotlin.verifyNoInteractions
 import org.mockito.kotlin.whenever
 import java.util.concurrent.CopyOnWriteArrayList
 import kotlin.test.Test
@@ -339,6 +341,37 @@ class ScopeTest {
         assertEquals(1, scope.breadcrumbs.count())
     }
 
+    @Test
+    fun `when adding breadcrumb and maxBreadcrumb is 0, beforeBreadcrumb is not executed`() {
+        var called = false
+        val options = SentryOptions().apply {
+            maxBreadcrumbs = 0
+            beforeBreadcrumb = SentryOptions.BeforeBreadcrumbCallback{ breadcrumb, _ ->
+                called = true
+                breadcrumb
+            }
+        }
+
+        val scope = Scope(options)
+        scope.addBreadcrumb(Breadcrumb())
+        assertEquals(0, scope.breadcrumbs.count())
+        assertFalse(called)
+    }
+
+    @Test
+    fun `when adding breadcrumb and maxBreadcrumb is 0, scopesObservers are not called`() {
+        val observer = mock<IScopeObserver>()
+        val options = SentryOptions().apply {
+            maxBreadcrumbs = 0
+            addScopeObserver(observer)
+        }
+
+        val scope = Scope(options)
+        scope.addBreadcrumb(Breadcrumb())
+        assertEquals(0, scope.breadcrumbs.count())
+        verifyNoInteractions(observer)
+    }
+
     @Test
     fun `when adding eventProcessor, eventProcessor should be in the list`() {
         val processor = CustomEventProcessor()