Skip to content

Commit b7da7e4

Browse files
runningcodeclaude
andcommitted
Fix CI compilation errors in DistributionHttpClient
- Update UpdateCheckParams constructor to use separate versionCode and versionName parameters - Replace Android Uri with string building for better compatibility - Remove unused Android Uri import - Update URL construction to use build_number and build_version query parameters This fixes the CI compilation errors where the old constructor expected a single 'version' parameter. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 2959cdb commit b7da7e4

File tree

3 files changed

+18
-23
lines changed

3 files changed

+18
-23
lines changed

sentry-android-distribution/src/main/java/io/sentry/android/distribution/DistributionHttpClient.kt

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.sentry.android.distribution
22

3-
import android.net.Uri
43
import io.sentry.SentryLevel
54
import io.sentry.SentryOptions
65
import java.io.BufferedReader
@@ -25,7 +24,8 @@ internal class DistributionHttpClient(private val options: SentryOptions) {
2524
val mainBinaryIdentifier: String,
2625
val appId: String,
2726
val platform: String = "android",
28-
val version: String,
27+
val versionCode: Int,
28+
val versionName: String,
2929
)
3030

3131
/**
@@ -47,22 +47,16 @@ internal class DistributionHttpClient(private val options: SentryOptions) {
4747
)
4848
}
4949

50-
val uri =
51-
Uri.parse(baseUrl)
52-
.buildUpon()
53-
.appendPath("api")
54-
.appendPath("0")
55-
.appendPath("projects")
56-
.appendPath(orgSlug)
57-
.appendPath(projectSlug)
58-
.appendPath("preprodartifacts")
59-
.appendPath("check-for-updates")
60-
.appendQueryParameter("main_binary_identifier", params.mainBinaryIdentifier)
61-
.appendQueryParameter("app_id", params.appId)
62-
.appendQueryParameter("platform", params.platform)
63-
.appendQueryParameter("version", params.version)
64-
.build()
65-
val url = URL(uri.toString())
50+
val urlString = buildString {
51+
append(baseUrl.trimEnd('/'))
52+
append("/api/0/projects/$orgSlug/$projectSlug/preprodartifacts/check-for-updates/")
53+
append("?main_binary_identifier=${params.mainBinaryIdentifier}")
54+
append("&app_id=${params.appId}")
55+
append("&platform=${params.platform}")
56+
append("&build_number=${params.versionCode}")
57+
append("&build_version=${params.versionName}")
58+
}
59+
val url = URL(urlString)
6660

6761
return try {
6862
makeRequest(url, authToken)

sentry-android-distribution/src/test/java/io/sentry/android/distribution/DistributionHttpClientTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ class DistributionHttpClientTest {
3636
DistributionHttpClient.UpdateCheckParams(
3737
mainBinaryIdentifier = "com.emergetools.hackernews",
3838
appId = "com.emergetools.hackernews",
39-
platform = "android",
40-
version = "1.0.0",
39+
versionName = "1.0.0",
40+
versionCode = 5,
4141
)
4242

4343
val response = httpClient.checkForUpdates(params)

sentry/src/main/java/io/sentry/UpdateInfo.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import org.jetbrains.annotations.ApiStatus;
44
import org.jetbrains.annotations.NotNull;
5+
import org.jetbrains.annotations.Nullable;
56

67
/** Information about an available app update. */
78
@ApiStatus.Experimental
@@ -11,15 +12,15 @@ public final class UpdateInfo {
1112
private final int buildNumber;
1213
private final @NotNull String downloadUrl;
1314
private final @NotNull String appName;
14-
private final @NotNull String createdDate;
15+
private final @Nullable String createdDate;
1516

1617
public UpdateInfo(
1718
final @NotNull String id,
1819
final @NotNull String buildVersion,
1920
final int buildNumber,
2021
final @NotNull String downloadUrl,
2122
final @NotNull String appName,
22-
final @NotNull String createdDate) {
23+
final @Nullable String createdDate) {
2324
this.id = id;
2425
this.buildVersion = buildVersion;
2526
this.buildNumber = buildNumber;
@@ -48,7 +49,7 @@ public int getBuildNumber() {
4849
return appName;
4950
}
5051

51-
public @NotNull String getCreatedDate() {
52+
public @Nullable String getCreatedDate() {
5253
return createdDate;
5354
}
5455
}

0 commit comments

Comments
 (0)