Revert "Lazily generate PropagationContext"

This reverts commit 398c5df.

Author: markushi

sentry/src/main/java/io/sentry/Scope.java

@@ -11,7 +11,6 @@
 import io.sentry.util.CollectionUtils;
 import io.sentry.util.EventProcessorUtils;
 import io.sentry.util.ExceptionUtils;
-import io.sentry.util.LazyEvaluator;
 import io.sentry.util.Objects;
 import io.sentry.util.Pair;
 import java.lang.ref.WeakReference;
@@ -94,7 +93,7 @@ public final class Scope implements IScope {
   /** Scope's attachments */
   private @NotNull List<Attachment> attachments = new CopyOnWriteArrayList<>();
 
-  private @NotNull LazyEvaluator<PropagationContext> propagationContext;
+  private @NotNull PropagationContext propagationContext;
 
   /** Scope's session replay id */
   private @NotNull SentryId replayId = SentryId.EMPTY_ID;
@@ -112,14 +111,7 @@ public final class Scope implements IScope {
   public Scope(final @NotNull SentryOptions options) {
     this.options = Objects.requireNonNull(options, "SentryOptions is required.");
     this.breadcrumbs = createBreadcrumbsList(this.options.getMaxBreadcrumbs());
-    this.propagationContext =
-        new LazyEvaluator<>(
-            new LazyEvaluator.Evaluator<PropagationContext>() {
-              @Override
-              public @NotNull PropagationContext evaluate() {
-                return new PropagationContext();
-              }
-            });
+    this.propagationContext = new PropagationContext();
     this.lastEventId = SentryId.EMPTY_ID;
   }
 
@@ -132,15 +124,6 @@ private Scope(final @NotNull Scope scope) {
     this.client = scope.client;
     this.lastEventId = scope.getLastEventId();
 
-    this.propagationContext =
-        new LazyEvaluator<>(
-            new LazyEvaluator.Evaluator<PropagationContext>() {
-              @Override
-              public @NotNull PropagationContext evaluate() {
-                return new PropagationContext();
-              }
-            });
-
     final User userRef = scope.user;
     this.user = userRef != null ? new User(userRef) : null;
     this.screen = scope.screen;
@@ -190,7 +173,7 @@ private Scope(final @NotNull Scope scope) {
 
     this.attachments = new CopyOnWriteArrayList<>(scope.attachments);
 
-    this.propagationContext.setValue(new PropagationContext(scope.propagationContext.getValue()));
+    this.propagationContext = new PropagationContext(scope.propagationContext);
   }
 
   /**
@@ -1082,7 +1065,7 @@ public void clearSession() {
   @ApiStatus.Internal
   @Override
   public void setPropagationContext(final @NotNull PropagationContext propagationContext) {
-    this.propagationContext.setValue(propagationContext);
+    this.propagationContext = propagationContext;
 
     final @NotNull SpanContext spanContext = propagationContext.toSpanContext();
     for (final IScopeObserver observer : options.getScopeObservers()) {
@@ -1093,17 +1076,16 @@ public void setPropagationContext(final @NotNull PropagationContext propagationC
   @ApiStatus.Internal
   @Override
   public @NotNull PropagationContext getPropagationContext() {
-    return propagationContext.getValue();
+    return propagationContext;
   }
 
   @ApiStatus.Internal
   @Override
   public @NotNull PropagationContext withPropagationContext(
       final @NotNull IWithPropagationContext callback) {
     try (final @NotNull ISentryLifecycleToken ignored = propagationContextLock.acquire()) {
-      final @NotNull PropagationContext context = getPropagationContext();
-      callback.accept(context);
-      return new PropagationContext(context);
+      callback.accept(propagationContext);
+      return new PropagationContext(propagationContext);
     }
   }