added app start option checks in SentryPerformanceProvider

Author: stefanosiano

sentry-android-core/src/main/java/io/sentry/android/core/SentryPerformanceProvider.java

@@ -139,7 +139,8 @@ private void launchAppStartProfiler(final @NotNull AppStartMetrics appStartMetri
         return;
       }
 
-      if (profilingOptions.isContinuousProfilingEnabled()) {
+      if (profilingOptions.isContinuousProfilingEnabled()
+          && profilingOptions.isStartProfilerOnAppStart()) {
         createAndStartContinuousProfiler(context, profilingOptions, appStartMetrics);
         return;
       }
@@ -150,8 +151,9 @@ private void launchAppStartProfiler(final @NotNull AppStartMetrics appStartMetri
         return;
       }
 
-      createAndStartTransactionProfiler(context, profilingOptions, appStartMetrics);
-
+      if (profilingOptions.isEnableAppStartProfiling()) {
+        createAndStartTransactionProfiler(context, profilingOptions, appStartMetrics);
+      }
     } catch (FileNotFoundException e) {
       logger.log(SentryLevel.ERROR, "App start profiling config file not found. ", e);
     } catch (Throwable e) {

sentry-android-core/src/test/java/io/sentry/android/core/SentryPerformanceProviderTest.kt

@@ -326,6 +326,22 @@ class SentryPerformanceProviderTest {
         assertFalse(AppStartMetrics.getInstance().appStartProfiler!!.isRunning)
     }
 
+    @Test
+    fun `when isEnableAppStartProfiling is false, transaction profiler is not started`() {
+        fixture.getSut { config ->
+            writeConfig(config, profilingEnabled = true, continuousProfilingEnabled = false, isEnableAppStartProfiling = false)
+        }
+        assertNull(AppStartMetrics.getInstance().appStartProfiler)
+    }
+
+    @Test
+    fun `when isStartProfilerOnAppStart is false, continuous profiler is not started`() {
+        fixture.getSut { config ->
+            writeConfig(config, profilingEnabled = false, continuousProfilingEnabled = true, isStartProfilerOnAppStart = false)
+        }
+        assertNull(AppStartMetrics.getInstance().appStartContinuousProfiler)
+    }
+
     @Test
     fun `when provider is closed, continuous profiler is stopped`() {
         val provider = fixture.getSut { config ->
@@ -345,6 +361,8 @@ class SentryPerformanceProviderTest {
         profileSampled: Boolean = true,
         profileSampleRate: Double = 1.0,
         continuousProfileSampled: Boolean = true,
+        isEnableAppStartProfiling: Boolean = true,
+        isStartProfilerOnAppStart: Boolean = true,
         profilingTracesDirPath: String = traceDir.absolutePath
     ) {
         val appStartProfilingOptions = SentryAppStartProfilingOptions()
@@ -357,6 +375,8 @@ class SentryPerformanceProviderTest {
         appStartProfilingOptions.isContinuousProfileSampled = continuousProfileSampled
         appStartProfilingOptions.profilingTracesDirPath = profilingTracesDirPath
         appStartProfilingOptions.profilingTracesHz = 101
+        appStartProfilingOptions.isEnableAppStartProfiling = isEnableAppStartProfiling
+        appStartProfilingOptions.isStartProfilerOnAppStart = isStartProfilerOnAppStart
         JsonSerializer(SentryOptions.empty()).serialize(appStartProfilingOptions, FileWriter(configFile))
     }
     //endregion

sentry-samples/sentry-samples-android/src/main/AndroidManifest.xml

@@ -112,8 +112,12 @@
         <!--    how to enable profiling when starting transactions -->
 <!--        <meta-data android:name="io.sentry.traces.profiling.sample-rate" android:value="1.0" />-->
 
-        <!--    how to enable app start profiling -->
-        <meta-data android:name="io.sentry.traces.profiling.enable-app-start" android:value="true" />
+        <!-- Enable profiling, adjust in production env -->
+        <meta-data android:name="io.sentry.traces.profiling.session-sample-rate" android:value="1.0" />
+        <!-- Set profiling lifecycle, can be `manual` or `trace` -->
+        <meta-data android:name="io.sentry.traces.profiling.lifecycle" android:value="manual" />
+        <!-- Enable profiling on app start -->
+        <meta-data android:name="io.sentry.traces.profiling.start-on-app-start" android:value="true" />
 
         <!--    how to disable the Activity auto instrumentation for tracing-->
         <!--    <meta-data android:name="io.sentry.traces.activity.enable" android:value="false" />-->