Commit e63ad34
ref(feedback): Deprecate SentryUserFeedbackButton (#5350)
* ref(feedback): Rename Dialog to Form across feedback APIs
Rename SentryUserFeedbackDialog to SentryUserFeedbackForm as the primary
class. Keep SentryUserFeedbackDialog as a deprecated subclass for backward
compatibility.
Also rename internal APIs to use Form naming consistently:
- IDialogHandler -> IFormHandler
- showDialog -> showForm
- setDialogHandler/getDialogHandler -> setFormHandler/getFormHandler
- AndroidUserFeedbackIDialogHandler -> AndroidUserFeedbackFormHandler
Add deprecated Sentry.showUserFeedbackDialog() overloads that delegate to
the new Sentry.showUserFeedbackForm() methods.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix(feedback): Preserve binary compatibility for deprecated Builder constructors
Use SentryUserFeedbackDialog.OptionsConfiguration as the parameter type
in the deprecated Builder constructors so old compiled code looking for
the original descriptor still resolves correctly.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Make internal ctor package-private
* Add missing deprecated annotaiton
* Fix api
* docs(changelog): Add deprecation entry for feedback Dialog to Form rename
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* docs(changelog): Note removal in next major version
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* feat(feedback): Add Sentry.feedback() API
Introduce IFeedbackApi with showForm() and capture() methods,
accessible via Sentry.feedback(). This consolidates all feedback
operations under a single API entry point.
Deprecate Sentry.showUserFeedbackForm(), Sentry.showUserFeedbackDialog(),
Sentry.captureFeedback(), and Sentry.captureUserFeedback() in favor of the
new Sentry.feedback() API. All deprecated methods will be removed in the
next major version.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* docs(changelog): Update section to Features and remove unpublished API
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* ref(feedback): Move FeedbackApi to IScopes
Add feedback() method to IScopes, matching the pattern used by
logger() and metrics(). FeedbackApi takes an IScopes reference instead
of using Sentry.getCurrentScopes() statically.
Implemented in Scopes, NoOpScopes, NoOpHub, HubAdapter, HubScopesWrapper,
and ScopesAdapter. Sentry.feedback() now delegates to
getCurrentScopes().feedback().
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* ref: Rename showForm() to show() on IFeedbackApi
Since the method is already namespaced under feedback(), the extra
"Form" suffix is redundant. This aligns with the convention used by
logger() and metrics().
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: Deprecate UserFeedback and captureUserFeedback, delete showUserFeedbackForm
Deprecate the old `UserFeedback` class and `captureUserFeedback()`
across IScopes, ISentryClient, and all implementations in favor of
`Sentry.feedback().capture()` with the new `Feedback` type.
Delete `Sentry.showUserFeedbackForm()` (3 overloads) as it was never
published.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: Deprecate SentryEnvelopeItem.fromUserFeedback()
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: Deprecate SentryClient.buildEnvelope(UserFeedback)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* ref: Remove unnecessary SuppressWarnings("deprecation")
Deprecated methods don't need to suppress deprecation warnings for
referencing other deprecated types — the deprecation annotation itself
is sufficient.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix test
* remove redudndant deprecated annotations
* fix test
* ref(feedback): Deprecate SentryUserFeedbackButton
* Changelog
* chore: Deprecate SentryUserFeedbackButton in sentry-compose
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* changelog
* message
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>1 parent 7659fe5 commit e63ad34
3 files changed
Lines changed: 11 additions & 0 deletions
File tree
- sentry-android-core/src/main/java/io/sentry/android/core
- sentry-compose/src/androidMain/kotlin/io/sentry/compose
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
13 | 17 | | |
14 | 18 | | |
15 | 19 | | |
16 | 20 | | |
| 21 | + | |
17 | 22 | | |
18 | 23 | | |
19 | 24 | | |
20 | 25 | | |
21 | 26 | | |
| 27 | + | |
22 | 28 | | |
23 | 29 | | |
24 | 30 | | |
25 | 31 | | |
26 | 32 | | |
| 33 | + | |
27 | 34 | | |
28 | 35 | | |
29 | 36 | | |
30 | 37 | | |
31 | 38 | | |
| 39 | + | |
32 | 40 | | |
33 | 41 | | |
34 | 42 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
0 commit comments