test(replay): Return CompletedFuture from close-race test mock to match executor contract

romtsn · claude · romtsn · commit fb275d7b1078 · 2026-07-24T12:56:34.000+02:00
The executorThatClosesFirst mock ran tasks inline but returned null, modeling a rejection path that never occurs during inline execution. Same fix as the inlineExecutor() fixture in cd3a7c0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
diff --git a/sentry-android-replay/src/test/java/io/sentry/android/replay/screenshot/PixelCopyStrategyTest.kt b/sentry-android-replay/src/test/java/io/sentry/android/replay/screenshot/PixelCopyStrategyTest.kt
@@ -141,7 +141,7 @@ class PixelCopyStrategyTest {
         // PixelCopyStrategy swallows the exception, so we have to capture it here and rethrow later
         failure.set(e)
       }
-      null
+      CompletedFuture
     }
 
     strategy = fixture.getSut(executor = executorThatClosesFirst)

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ class PixelCopyStrategyTest {`
`141`	`141`	`// PixelCopyStrategy swallows the exception, so we have to capture it here and rethrow later`
`142`	`142`	`failure.set(e)`
`143`	`143`	`}`
`144`		`- null`
	`144`	`+ CompletedFuture`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`strategy = fixture.getSut(executor = executorThatClosesFirst)`