Java SDK check truncation logic

[adinauer]

Description

see https://github.com/getsentry/projects/issues/837

we should reconsider whether any truncation logic in the SDK can be removed or whether it's still required (e.g. to avoid (near) endless recursion)

[adinauer]

sentry-java/sentry/src/main/java/io/sentry/protocol/Feedback.java

Lines 91 to 98 in c626414

	public void setMessage(final @NotNull String message) {
	// Sentry limits the message to 4096 characters
	if (message.length() > 4096) {
	this.message = message.substring(0, 4096);
	} else {
	this.message = message;
	}
	}

[adinauer]

This one we should keep since it's there to prevent blowing up the customers application:

sentry-java/sentry/src/main/java/io/sentry/SentryStackTraceFactory.java

Lines 63 to 65 in 8fd337b

	if (sentryStackFrames.size() >= STACKTRACE_FRAME_LIMIT) {
	break;
	}

[adinauer]

sentry-java/sentry/src/main/java/io/sentry/protocol/Message.java

Lines 32 to 50 in c626414

	public final class Message implements JsonUnknown, JsonSerializable {
	/**
	* The formatted message. If `message` and `params` are given, Sentry will attempt to backfill
	* `formatted` if empty.
	*
	* <p>It must not exceed 8192 characters. Longer messages will be truncated.
	*/
	private @Nullable String formatted;
	/**
	* The log message with parameter placeholders.
	*
	* <p>This attribute is primarily used for grouping related events together into issues. Therefore
	* this really should just be a string template, i.e. `Sending %d requests` instead of `Sending
	* 9999 requests`. The latter is much better at home in `formatted`.
	*
	* <p>It must not exceed 8192 characters. Longer messages will be truncated.
	*/
	private @Nullable String message;

[adinauer]

sentry-java/sentry/src/main/java/io/sentry/protocol/SentryStackFrame.java

Lines 135 to 152 in c626414

	/**
	* A raw (but potentially truncated) function value.
	*
	* <p>The original function name, if the function name is shortened or demangled. Sentry shows the
	* raw function when clicking on the shortened one in the UI.
	*
	* <p>If this has the same value as `function` it's best to be omitted. This exists because on
	* many platforms the function itself contains additional information like overload specifies or a
	* lot of generics which can make it exceed the maximum limit we provide for the field. In those
	* cases then we cannot reliably trim down the function any more at a later point because the more
	* valuable information has been removed.
	*
	* <p>The logic to be applied is that an intelligently trimmed function name should be stored in
	* `function` and the value before trimming is stored in this field instead. However also this
	* field will be capped at 256 characters at the moment which often means that not the entire
	* original value can be stored.
	*/
	private @Nullable String rawFunction;

[adinauer]

Baggage limits are following the spec so we don't produce invalid baggage headers. We should keep this:

sentry-java/sentry/src/main/java/io/sentry/Baggage.java

Lines 288 to 307 in c626414

	if (listMemberCount >= MAX_BAGGAGE_LIST_MEMBER_COUNT) {
	logger.log(
	SentryLevel.ERROR,
	"Not adding baggage value %s as the total number of list members would exceed the maximum of %s.",
	key,
	MAX_BAGGAGE_LIST_MEMBER_COUNT);
	} else {
	try {
	final String encodedKey = encode(key);
	final String encodedValue = encode(value);
	final String encodedKeyValue = separator + encodedKey + "=" + encodedValue;
	final int valueLength = encodedKeyValue.length();
	final int totalLengthIfValueAdded = sb.length() + valueLength;
	if (totalLengthIfValueAdded > MAX_BAGGAGE_STRING_LENGTH) {
	logger.log(
	SentryLevel.ERROR,
	"Not adding baggage value %s as the total header value length would exceed the maximum of %s.",
	key,
	MAX_BAGGAGE_STRING_LENGTH);

[adinauer]

sentry-java/sentry-android-core/src/main/java/io/sentry/android/core/SpanFrameMetricsCollector.java

Lines 251 to 255 in c626414

	// buffer is full, skip adding new frames for now
	// once a span finishes, the buffer will trimmed
	if (frames.size() > MAX_FRAMES_COUNT) {
	return;
	}

[adinauer]

sentry-java/sentry/src/main/java/io/sentry/SentryEnvelopeItem.java

Lines 297 to 298 in c626414

	final byte[] traceFileBytes =
	readBytesFromFile(traceFile.getPath(), MAX_PROFILE_CHUNK_SIZE);