The javadoc of Sentry.flush says it's not implemented, despite it being implemented

[craftamap]

Integration

sentry

Java Version

21

Version

8.5.0

Steps to Reproduce

1. Go to

   sentry-java/sentry/src/main/java/io/sentry/Sentry.java

   Line 1033 in a1ad6ae

   * Flushes events queued up to the current Scopes. Not implemented yet.

Expected Result

No no-op comment.

This tripped me up when using the method, as I was confused if this even does something. Looking into the implementation with a debugger revealed that it does end up flushing the entities (In io.sentry.transport.QueuedThreadPoolExecutor#waitTillIdle).

I guess this is dependent on the Transport implementation chosen.

Actual Result

N/A

[philprime]

Hi @craftamap, thanks for bringing this up.

@romtsn @markushi can you give some insights here if this method is always not implemented or depending on configuration?

[adinauer]

Thanks for opening this issue. Will send a PR to remove the part of the comment.