Throwable is missing in transaction

[zhukic]

Integration

sentry-android

Build System

Gradle

AGP Version

8.9.1

Proguard

Enabled

Version

8.8.0

Steps to Reproduce

Hi,

I've implemented a custom OkHttp interceptor that measures the time taken to execute an HTTP request(described here). It goes well but in case if a request fails due to some exception we don't see the exception in Sentry, only the transaction's status.

Pseudocode:

class HttpLoggingInterceptor() : Interceptor {

    override fun intercept(chain: Interceptor.Chain): Response {
        val request = chain.request()
        val transaction = Sentry.startTransaction(name = request.path, operation = "http.client")
        // A separate span needed for having calls on the "Network Requests" page
        val span = transaction.startChild(operation = "http.client", description = "${request.method} $path")

        return try {
            val response = chain.proceed(request)
            val status = SpanStatus.fromHttpStatusCode(response.code)
            transaction.setData(KEY_HTTP_RESPONSE_CODE, code)
            span.setData(KEY_HTTP_RESPONSE_CODE, code)

            response
        } catch (e: Exception) {
            transaction.throwable = exception
            transaction.status = SpanStatus.INTERNAL_ERROR
            span.throwable = exception
            span.status = SpanStatus.INTERNAL_ERROR

            throw e
        } finally {
            span.finish()
            transaction.finish()
        }
    }
}

When an exception occurs, I see on the debug panel that the transaction.throwable field is not null during transaction.finish() call, but when I put a breakpoint on my custom EventProcessor the throwable is missing and it's missing on the transaction's page as well.

Expected Result

The throwable is presented on the transaction's page.

Actual Result

The throwable is missing.

[romtsn]

Hey, thanks for the issue. Yes, that throwable is not serialized and we just use it internally to map back to any exception that happened while the transaction lasted. If you want those exceptions to show up in Sentry, you'd still have to captureEvent as we do here.

I honestly think you don't even have to set the throwable to transactions anymore, because they should get linked automatically via trace_id, but it might still be needed for some things, so feel free to keep it.

Hope this helps, feel free to reply here if there's still an issue. Thanks!

[zhukic]

@romtsn Sorry, it's still unclear for me. If a some network IO exception(ConnectionException, TimeoutException, for example) occurred and it got caught here, I would like to see on the transaction's page. But currently, I just see internal_error status and nothing else

[romtsn]

@zhukic that's because we do not send that throwable as part of the transaction. As mentioned, it has to be explicitly captured via Sentry.captureException/captureEvent and only then it will get linked to your transaction and show up on the transaction's page.