Use graphql-java v24 for Spring Boot 3.5#4444
Merged
Conversation
adinauer
requested review from
lcian,
markushi,
romtsn and
stefanosiano
as code owners
Contributor
|
lbloder
approved these changes
May 23, 2025
Collaborator
lbloder
left a comment
lbloder
left a comment
There was a problem hiding this comment.
Minor comment about naming, otherwise LGTM
|
|
||
| val graphQlJava = "com.graphql-java:graphql-java:17.3" | ||
| val graphQlJava22 = "com.graphql-java:graphql-java:22.1" | ||
| val graphQlJavaNew = "com.graphql-java:graphql-java:24.0" |
Collaborator
There was a problem hiding this comment.
Should we go with major versions for the name like before? I.e. graphQlJava24?
Member
Author
There was a problem hiding this comment.
I thought about it but think it's better to skip the version in the name since we probably want to keep this aligned with Spring Boots required version in the future.
Or it would be even better to have Spring Boot take care of handling the version via its gradle plugin.
chromy
approved these changes
May 23, 2025
3 tasks
Member
Author
|
I opted for not bumping the version used in our |
3 tasks
rbro112
pushed a commit
that referenced
this pull request
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Use
graphql-javav24 for Spring Boot 3.5💡 Motivation and Context
Compilation error due to v22 of
graphql-javabeing used.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps