Merged
Conversation
runningcode
requested review from
adinauer,
lcian,
markushi,
romtsn and
stefanosiano
as code owners
Add build caching for spotless format execution
Contributor
Performance metrics 🚀
|
romtsn
approved these changes
Jun 6, 2025
stefanosiano
approved these changes
Jun 18, 2025
Contributor
stefanosiano
left a comment
stefanosiano
left a comment
There was a problem hiding this comment.
just saw you opened the issue in gradle about it years ago :D
Contributor
Author
|
Ah yeah, the one about having a hermetic testing environment? Still hasn’t become a thing unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This removes the redundant dependency on
cleanTestfrom each test task. This still allows the test to come from the cache so it doesn't really make sense.Also add build caching for spotless format execution
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps