Fix tag extraction logic, bump to Timber 5.0.1#4489
Closed
Conversation
Contributor
Performance metrics 🚀
|
romtsn
reviewed
Jun 18, 2025
| message: String?, | ||
| vararg args: Any? | ||
| ) { | ||
| val tag = explicitTag.get() |
Member
There was a problem hiding this comment.
hm, but am I missing something or this ain't gonna work for Timber < 5? Because we only define it as compileOnly so if the hosting app is using a lower version it will crash?
Member
Author
|
Closing this PR as it only works for Timber 5.x and does not seem to fix the underlying root issue of ThreadLocal usages within the Timber library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Timber 5.+ switched to Kotlin, allowing us to directly access the internal
tagvalue, instead of the existing workaround.According to the release Timber 5.x is binary compatible: https://github.com/JakeWharton/timber/releases/tag/5.0.0 so we should be good with just bumping the version here.
💡 Motivation and Context
Fixes #4484
💚 How did you test it?
Added extra unit tests.
We should still manually test compatibility with Timber 4.x, as the internal tag value was declared the following:
And with 5.x it's
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps