diff --git a/CHANGELOG.md b/CHANGELOG.md index 6b78d843b20..74c6aed7e84 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ - Log parameter objects are now turned into `String` via `toString` ([#4515](https://github.com/getsentry/sentry-java/pull/4515)) - One of the two `SentryLogEventAttributeValue` constructors did not convert the value previously. - Logs are now flushed on shutdown ([#4503](https://github.com/getsentry/sentry-java/pull/4503)) +- User Feedback: Do not redefine system attributes for `SentryUserFeedbackButton`, but reference them instead ([#4519](https://github.com/getsentry/sentry-java/pull/4519)) ### Features diff --git a/sentry-android-core/src/main/java/io/sentry/android/core/SentryUserFeedbackDialog.java b/sentry-android-core/src/main/java/io/sentry/android/core/SentryUserFeedbackDialog.java index dc5ead7d6c8..39fff9c7168 100644 --- a/sentry-android-core/src/main/java/io/sentry/android/core/SentryUserFeedbackDialog.java +++ b/sentry-android-core/src/main/java/io/sentry/android/core/SentryUserFeedbackDialog.java @@ -12,6 +12,7 @@ import io.sentry.IScopes; import io.sentry.Sentry; import io.sentry.SentryFeedbackOptions; +import io.sentry.SentryIntegrationPackageStorage; import io.sentry.SentryLevel; import io.sentry.SentryOptions; import io.sentry.protocol.Feedback; @@ -34,6 +35,7 @@ public final class SentryUserFeedbackDialog extends AlertDialog { final @Nullable OptionsConfiguration configuration) { super(context, themeResId); this.configuration = configuration; + SentryIntegrationPackageStorage.getInstance().addIntegration("UserFeedbackWidget"); } @Override diff --git a/sentry-android-core/src/main/res/values/attrs.xml b/sentry-android-core/src/main/res/values/attrs.xml index c464cf29f0a..efb5651d5da 100644 --- a/sentry-android-core/src/main/res/values/attrs.xml +++ b/sentry-android-core/src/main/res/values/attrs.xml @@ -1,12 +1,13 @@ + - - - - - - - + + + + + + + diff --git a/sentry-android-integration-tests/sentry-uitest-android/src/main/res/values/values.xml b/sentry-android-integration-tests/sentry-uitest-android/src/main/res/values/values.xml index 7763c15cd1a..e19e9de7452 100644 --- a/sentry-android-integration-tests/sentry-uitest-android/src/main/res/values/values.xml +++ b/sentry-android-integration-tests/sentry-uitest-android/src/main/res/values/values.xml @@ -1,4 +1,15 @@ + + + + + + + + + + + true