Skip to content

Restore span names for GraphQL on the new version of OpenTelemetry (by changing OpenTelemetry defaults) #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adinauer merged 5 commits into from
Jul 3, 2025
Merged

Restore span names for GraphQL on the new version of OpenTelemetry (by changing OpenTelemetry defaults) #4537

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aed6b3b
do not override span name if customized
adinauer Jul 3, 2025
ef814c1
Format code
getsentry-bot Jul 3, 2025
0af3767
log in case system property cannot be set
adinauer Jul 3, 2025
2def353
merge
adinauer Jul 3, 2025
4f5e29d
changelog
adinauer Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ...tion/src/main/java/io/sentry/opentelemetry/SentryAutoConfigurationCustomizerProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,23 @@
import io.sentry.protocol.SentryPackage;
import java.util.HashMap;
import java.util.Map;
import java.util.logging.Level;
import java.util.logging.Logger;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

public final class SentryAutoConfigurationCustomizerProvider
implements AutoConfigurationCustomizerProvider {

private static final Logger logger =
Logger.getLogger(SentryAutoConfigurationCustomizerProvider.class.getName());

public static volatile boolean skipInit = false;

@Override
public void customize(AutoConfigurationCustomizer autoConfiguration) {
ensureSentryOtelStorageIsInitialized();
customizeOpenTelemetryDefaults();
final @Nullable ManifestVersionReader.VersionInfoHolder versionInfoHolder =
ManifestVersionReader.getInstance().readOpenTelemetryVersion();

Expand Down Expand Up @@ -63,6 +69,18 @@ private static void ensureSentryOtelStorageIsInitialized() {
Sentry.getGlobalScope();
}

private void customizeOpenTelemetryDefaults() {
try {
if (System.getProperty("otel.instrumentation.graphql.add-operation-name-to-span-name.enabled")
== null) {
System.setProperty(
"otel.instrumentation.graphql.add-operation-name-to-span-name.enabled", "true");
}
} catch (Exception e) {
logger.log(Level.WARNING, "Unable to change OpenTelemetry defaults for use with Sentry.", e);
}
}

private boolean isSentryAutoInitEnabled() {
if (skipInit) {
return false;
Expand Down
Loading