Skip to content

Do not use Sentry logging API in Log4j2 if logs are disabled #4573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adinauer merged 4 commits into from
Jul 29, 2025
Merged

Do not use Sentry logging API in Log4j2 if logs are disabled #4573

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e71d692
Do not use Sentry logging API if logs are disabled
adinauer Jul 29, 2025
dff3aa9
Format code
getsentry-bot Jul 29, 2025
c93b2d1
changelog
adinauer Jul 29, 2025
c9187e9
mention log4j2 in changelog entry
adinauer Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sentry-log4j2/src/main/java/io/sentry/log4j2/SentryAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,8 @@ public void start() {

@Override
public void append(final @NotNull LogEvent eventObject) {
if (eventObject.getLevel().isMoreSpecificThan(minimumLevel)) {
if (scopes.getOptions().getLogs().isEnabled()
&& eventObject.getLevel().isMoreSpecificThan(minimumLevel)) {
captureLog(eventObject);
}
if (eventObject.getLevel().isMoreSpecificThan(minimumEventLevel)) {
Expand Down
1 change: 1 addition & 0 deletions sentry-samples/sentry-samples-log4j2/src/main/resources/sentry.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
in-app-includes="io.sentry.samples"
logs.enabled=true
debug=true