Skip to content

fix(security): Add integrity verification before chmod +x in btrace-perfetto skill #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romtsn merged 2 commits into from
Apr 20, 2026
+20 −1
Merged

fix(security): Add integrity verification before chmod +x in btrace-perfetto skill #5297

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7b4981
fix(security): Add integrity verification before chmod +x in btrace-p…
fix-it-felix-sentry[bot] Apr 17, 2026
94447ba
fix(security): Verify magic bytes instead of file(1) for trace_processor
romtsn Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .claude/skills/btrace-perfetto/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,18 @@ Before starting, verify:
```
3. **Perfetto trace_processor**: Check if `/tmp/trace_processor` exists. If not, download it:
```bash
curl -sL "https://get.perfetto.dev/trace_processor" -o /tmp/trace_processor && chmod +x /tmp/trace_processor
# Download trace_processor
curl -sL "https://get.perfetto.dev/trace_processor" -o /tmp/trace_processor

# Verify the file is a valid executable (check file type and size)
if [[ ! -s /tmp/trace_processor ]] || ! file /tmp/trace_processor | grep -q "executable"; then
Comment thread
romtsn marked this conversation as resolved.
Outdated
echo "Error: Downloaded file is not a valid executable"
rm -f /tmp/trace_processor
exit 1
fi

# Make executable only after verification
chmod +x /tmp/trace_processor
```
4. **Device ABI**: Run `adb shell getprop ro.product.cpu.abi` — btrace only supports arm64-v8a and armeabi-v7a (no x86/x86_64)

Expand Down
Loading