fix(sentry-okhttp): Skip synthetic 504 for FORCE_CACHE cache misses#5299
Open
fix(sentry-okhttp): Skip synthetic 504 for FORCE_CACHE cache misses#5299
Conversation
OkHttp's CacheInterceptor synthesizes a 504 "Unsatisfiable Request" response when a request with `only-if-cached` (e.g. CacheControl.FORCE_CACHE) misses the cache. This is not a real server error, so don't capture it as a failed request event. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
📲 Install BuildsAndroid
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
OkHttp's
CacheInterceptorsynthesizes a 504 "Unsatisfiable Request" response when a request withonly-if-cached(e.g.CacheControl.FORCE_CACHE) misses the cache. This is not a real server error, so we should not capture it as a failed request event.This PR adds a check in
SentryOkHttpInterceptorto skip reporting when the response is a 504 and the request hasonlyIfCachedset.💡 Motivation and Context
💚 How did you test it?
FORCE_CACHEcache miss (verifies no event is captured)onlyIfCached(verifies event is still captured)SentryOkHttpInterceptorTestsuite — all tests pass📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps