Skip to content

refactor(android-sqlite): Rename classes instrumenting SQLite spans for consistency#5555

Open
0xadam-brown wants to merge 1 commit into
mainfrom
chore/rename-sqlite-instrumentation-classes
Open

refactor(android-sqlite): Rename classes instrumenting SQLite spans for consistency#5555
0xadam-brown wants to merge 1 commit into
mainfrom
chore/rename-sqlite-instrumentation-classes

Conversation

@0xadam-brown

Copy link
Copy Markdown
Member

📜 Description

Follow up to #5543.

Now that SQLiteSpanInstrumentation solely services the SentrySQLiteDriver path, we can give it a name specific to the driver (and therefore less confusing). Doing so also gives us a chance to bring its name in line with the analogous SQLiteSpanManager.

PR renames as follows:

  • SQLiteSpanManager -> OpenHelperSpans
  • SQLiteSpanInstrumentation -> DriverSpans

That^^ also lets us avoid the '-er' syndrom Roman mentioned here.

💡 Motivation and Context

Keeping things neat and tidy.

💚 How did you test it?

N/a

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@0xadam-brown 0xadam-brown changed the title chore(android-sqlite): Rename classes instrumenting SQLite spans for consistency refactorandroid-sqlite): Rename classes instrumenting SQLite spans for consistency Jun 17, 2026
@0xadam-brown 0xadam-brown changed the title refactorandroid-sqlite): Rename classes instrumenting SQLite spans for consistency refactor(android-sqlite): Rename classes instrumenting SQLite spans for consistency Jun 17, 2026
@0xadam-brown 0xadam-brown force-pushed the chore/rename-sqlite-instrumentation-classes branch from 6906a95 to 1d573f3 Compare June 17, 2026 10:06
@sentry

sentry Bot commented Jun 17, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.43.2 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 317.47 ms 394.62 ms 77.15 ms
Size 0 B 0 B 0 B

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a416a65 333.78 ms 410.37 ms 76.59 ms
d15471f 304.55 ms 408.43 ms 103.87 ms
ca6b6d8 380.45 ms 460.38 ms 79.93 ms
c8125f3 397.65 ms 485.14 ms 87.49 ms
b936425 302.69 ms 372.86 ms 70.17 ms
ed33deb 334.19 ms 362.30 ms 28.11 ms
cf708bd 408.35 ms 458.98 ms 50.63 ms
eb95ded 317.51 ms 369.08 ms 51.57 ms
a5ab36f 320.47 ms 389.77 ms 69.30 ms
80fd6ad 321.06 ms 375.79 ms 54.73 ms

App size

Revision Plain With Sentry Diff
a416a65 1.58 MiB 2.12 MiB 555.26 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
ca6b6d8 0 B 0 B 0 B
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
b936425 0 B 0 B 0 B
ed33deb 1.58 MiB 2.13 MiB 559.52 KiB
cf708bd 1.58 MiB 2.11 MiB 539.71 KiB
eb95ded 0 B 0 B 0 B
a5ab36f 1.58 MiB 2.12 MiB 555.26 KiB
80fd6ad 0 B 0 B 0 B

Previous results on branch: chore/rename-sqlite-instrumentation-classes

Startup times

Revision Plain With Sentry Diff
9fdc9f0 356.04 ms 428.61 ms 72.57 ms

App size

Revision Plain With Sentry Diff
9fdc9f0 0 B 0 B 0 B

Base automatically changed from chore/offset-sqlite-start-timestamps to main June 17, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant