fix(plugin-manager): Enable "rejectOnError" in debug (#837)

* fix(plugin-manager): Enable "rejectOnError" in debug

* fix ci fails

Author: s1gr1d

packages/bundler-plugin-core/src/build-plugin-manager.ts

@@ -555,7 +555,7 @@ export function createSentryBuildPluginManager(
             const cliInstance = createCliInstance(options);
             await cliInstance.execute(
               ["sourcemaps", "inject", ...buildArtifactPaths],
-              options.debug ?? false
+              options.debug ? "rejectOnError" : false
             );
           } catch (e) {
             sentryScope.captureException('Error in "debugIdInjectionPlugin" writeBundle hook');

packages/bundler-plugin-core/test/build-plugin-manager.test.ts

@@ -439,7 +439,7 @@ describe("createSentryBuildPluginManager", () => {
       );
     });
 
-    it("should pass debug flag when options.debug is true", async () => {
+    it('should pass "rejectOnError" flag when options.debug is true', async () => {
       mockCliExecute.mockResolvedValue(undefined);
 
       const buildPluginManager = createSentryBuildPluginManager(
@@ -460,7 +460,7 @@ describe("createSentryBuildPluginManager", () => {
 
       expect(mockCliExecute).toHaveBeenCalledWith(
         ["sourcemaps", "inject", "/path/to/bundle"],
-        true
+        "rejectOnError"
       );
     });
   });

yarn.lock

@@ -8109,15 +8109,6 @@ istanbul-reports@^3.1.3:
     html-escaper "^2.0.0"
     istanbul-lib-report "^3.0.0"
 
-jackspeak@^2.0.3:
-  version "2.2.1"
-  resolved "https://registry.npmjs.org/jackspeak/-/jackspeak-2.2.1.tgz#655e8cf025d872c9c03d3eb63e8f0c024fef16a6"
-  integrity sha512-MXbxovZ/Pm42f6cDIDkl3xpwv1AGwObKwfmjs2nQePiy85tP3fatofl3FC1aBsOtP/6fq5SbtgHwWcMsLP+bDw==
-  dependencies:
-    "@isaacs/cliui" "^8.0.2"
-  optionalDependencies:
-    "@pkgjs/parseargs" "^0.11.0"
-
 jackspeak@^3.1.2:
   version "3.4.3"
   resolved "https://registry.npmjs.org/jackspeak/-/jackspeak-3.4.3.tgz#8833a9d89ab4acde6188942bd1c53b6390ed5a8a"
@@ -9608,7 +9599,7 @@ minimatch@^8.0.2:
   dependencies:
     brace-expansion "^2.0.1"
 
-minimatch@^9.0.0, minimatch@^9.0.1:
+minimatch@^9.0.0:
   version "9.0.1"
   resolved "https://registry.npmjs.org/minimatch/-/minimatch-9.0.1.tgz#8a555f541cf976c622daf078bb28f29fb927c253"
   integrity sha512-0jWhJpD/MdhPXwPuiRkCbfYfSKp2qnn2eOc279qI7f+osl/l+prKSrvhg157zSYvx/1nmgn2NqdT6k2Z7zSH9w==
@@ -10764,7 +10755,7 @@ path-scurry@^1.11.1:
     lru-cache "^10.2.0"
     minipass "^5.0.0 || ^6.0.2 || ^7.0.0"
 
-path-scurry@^1.6.1, path-scurry@^1.7.0:
+path-scurry@^1.6.1:
   version "1.9.2"
   resolved "https://registry.npmjs.org/path-scurry/-/path-scurry-1.9.2.tgz#90f9d296ac5e37e608028e28a447b11d385b3f63"
   integrity sha512-qSDLy2aGFPm8i4rsbHd4MNyTcrzHFsLQykrtbuGRknZZCBBVXSv2tSCDN2Cg6Rt/GFRw8GoW9y9Ecw5rIPG1sg==