fix(plugin-manager): Respect sourcemap.ignore values for injecting debugIDs

Author: s1gr1d

packages/bundler-plugin-core/src/build-plugin-manager.ts

@@ -23,6 +23,7 @@ import {
   arrayify,
   getProjects,
   getTurborepoEnvPassthroughWarning,
+  serializeIgnoreOptions,
   stripQueryAndHashFromPath,
 } from "./utils";
 import { glob } from "glob";
@@ -554,8 +555,13 @@ export function createSentryBuildPluginManager(
           try {
             const cliInstance = createCliInstance(options);
             await cliInstance.execute(
-              ["sourcemaps", "inject", ...buildArtifactPaths],
               options.debug ?? false
+              [
+                "sourcemaps",
+                "inject",
+                ...serializeIgnoreOptions(options.sourcemaps?.ignore),
+                ...buildArtifactPaths,
+              ],
             );
           } catch (e) {
             sentryScope.captureException('Error in "debugIdInjectionPlugin" writeBundle hook');

packages/bundler-plugin-core/src/utils.ts

@@ -408,3 +408,23 @@ export function getProjects(project: string | string[] | undefined): string[] |
 
   return undefined;
 }
+
+/**
+ * Inlined functionality from @sentry/cli helper code to add `--ignore` options.
+ *
+ * Temporary workaround until we expose a function for injecting debug IDs. Currently, we directly call `execute` with CLI args to inject them.
+ */
+export function serializeIgnoreOptions(ignoreValue: string | string[] | undefined): string[] {
+  const DEFAULT_IGNORE = ["node_modules"];
+
+  const ignoreOptions: string[] = Array.isArray(ignoreValue)
+    ? ignoreValue
+    : typeof ignoreValue === "string"
+    ? [ignoreValue]
+    : DEFAULT_IGNORE;
+
+  return ignoreOptions.reduce(
+    (acc, value) => acc.concat(["--ignore", String(value)]),
+    [] as string[]
+  );
+}

packages/bundler-plugin-core/test/utils.test.ts

@@ -5,6 +5,7 @@ import {
   getPackageJson,
   parseMajorVersion,
   replaceBooleanFlagsInCode,
+  serializeIgnoreOptions,
   stringToUUID,
 } from "../src/utils";
 
@@ -270,3 +271,25 @@ describe("generateModuleMetadataInjectorCode", () => {
     expect(generatedCode).toMatchSnapshot();
   });
 });
+
+describe("serializeIgnoreOptions", () => {
+  it("returns default ignore options when undefined", () => {
+    const result = serializeIgnoreOptions(undefined);
+    expect(result).toEqual(["--ignore", "node_modules"]);
+  });
+
+  it("handles array of ignore patterns", () => {
+    const result = serializeIgnoreOptions(["dist", "**/build/**", "*.log"]);
+    expect(result).toEqual(["--ignore", "dist", "--ignore", "**/build/**", "--ignore", "*.log"]);
+  });
+
+  it("handles single string pattern", () => {
+    const result = serializeIgnoreOptions("dist");
+    expect(result).toEqual(["--ignore", "dist"]);
+  });
+
+  it("handles empty array", () => {
+    const result = serializeIgnoreOptions([]);
+    expect(result).toEqual([]);
+  });
+});

yarn.lock

@@ -8109,15 +8109,6 @@ istanbul-reports@^3.1.3:
     html-escaper "^2.0.0"
     istanbul-lib-report "^3.0.0"
 
-jackspeak@^2.0.3:
-  version "2.2.1"
-  resolved "https://registry.npmjs.org/jackspeak/-/jackspeak-2.2.1.tgz#655e8cf025d872c9c03d3eb63e8f0c024fef16a6"
-  integrity sha512-MXbxovZ/Pm42f6cDIDkl3xpwv1AGwObKwfmjs2nQePiy85tP3fatofl3FC1aBsOtP/6fq5SbtgHwWcMsLP+bDw==
-  dependencies:
-    "@isaacs/cliui" "^8.0.2"
-  optionalDependencies:
-    "@pkgjs/parseargs" "^0.11.0"
-
 jackspeak@^3.1.2:
   version "3.4.3"
   resolved "https://registry.npmjs.org/jackspeak/-/jackspeak-3.4.3.tgz#8833a9d89ab4acde6188942bd1c53b6390ed5a8a"
@@ -9608,7 +9599,7 @@ minimatch@^8.0.2:
   dependencies:
     brace-expansion "^2.0.1"
 
-minimatch@^9.0.0, minimatch@^9.0.1:
+minimatch@^9.0.0:
   version "9.0.1"
   resolved "https://registry.npmjs.org/minimatch/-/minimatch-9.0.1.tgz#8a555f541cf976c622daf078bb28f29fb927c253"
   integrity sha512-0jWhJpD/MdhPXwPuiRkCbfYfSKp2qnn2eOc279qI7f+osl/l+prKSrvhg157zSYvx/1nmgn2NqdT6k2Z7zSH9w==
@@ -10764,7 +10755,7 @@ path-scurry@^1.11.1:
     lru-cache "^10.2.0"
     minipass "^5.0.0 || ^6.0.2 || ^7.0.0"
 
-path-scurry@^1.6.1, path-scurry@^1.7.0:
+path-scurry@^1.6.1:
   version "1.9.2"
   resolved "https://registry.npmjs.org/path-scurry/-/path-scurry-1.9.2.tgz#90f9d296ac5e37e608028e28a447b11d385b3f63"
   integrity sha512-qSDLy2aGFPm8i4rsbHd4MNyTcrzHFsLQykrtbuGRknZZCBBVXSv2tSCDN2Cg6Rt/GFRw8GoW9y9Ecw5rIPG1sg==