feat!: Remove support for Node < v18 and webpack v4 (#886)

* feat!: Remove support for Node < v18

* Fix dependency review

Author: timfish

.github/dependency-review-config.yml

@@ -0,0 +1,4 @@
+fail-on-severity: "critical"
+allow-ghsas:
+  # If we support webpack v5.0.0, we need to use those types and test that version
+  - GHSA-hc6q-2mpp-qw7j

.github/workflows/checks.yml

@@ -131,17 +131,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [
-            # nx uses a `yargs-parser` versision which isn't compatible with node 10
-            # "10.24.1",
-            # vite uses optional chaining which isn't compatible with node 12
-            # "12.22.12",
-            "14",
-            "16",
-            "18",
-            "20",
-            "22",
-          ]
+        node-version: ["18", "20", "22"]
         os: [ubuntu-latest, windows-latest]
     runs-on: ${{ matrix.os }}
     steps:

README.md

@@ -6,7 +6,7 @@
 
 # Sentry Bundler Plugins
 
-Sentry plugins for various JavaScript bundlers. Currently supporting Rollup, Vite, esbuild, Webpack 4 and Webpack 5.
+Sentry plugins for various JavaScript bundlers. Currently supporting Rollup, Vite, esbuild, Webpack 5.
 
 Check out the individual packages for more information and examples:
 

packages/e2e-tests/package.json

@@ -28,7 +28,6 @@
     "@types/axios": "^0.14.0",
     "@types/glob": "8.0.0",
     "@types/jest": "^28.1.3",
-    "@types/webpack4": "npm:@types/webpack@^4",
     "esbuild": "0.14.49",
     "eslint": "^8.18.0",
     "glob": "8.0.3",
@@ -37,8 +36,7 @@
     "rollup": "3.2.0",
     "ts-node": "^10.9.1",
     "vite": "3.0.0",
-    "webpack4": "npm:webpack@^4",
-    "webpack5": "npm:webpack@5.74.0"
+    "webpack": "5.74.0"
   },
   "volta": {
     "extends": "../../package.json"

packages/e2e-tests/utils/bundlers.ts

@@ -1 +1 @@
-export const BUNDLERS = ["rollup", "vite", "esbuild", "webpack4", "webpack5"];
+export const BUNDLERS = ["rollup", "vite", "esbuild", "webpack"];

packages/e2e-tests/utils/create-cjs-bundles.ts

@@ -1,8 +1,7 @@
 import * as vite from "vite";
 import * as path from "path";
 import * as rollup from "rollup";
-import { default as webpack4 } from "webpack4";
-import { webpack as webpack5 } from "webpack5";
+import { webpack } from "webpack";
 import * as esbuild from "esbuild";
 
 import type { Options } from "@sentry/bundler-plugin-core";
@@ -91,43 +90,13 @@ export function createCjsBundles(
     format: "cjs",
   });
 
-  webpack4(
-    {
-      devtool: "source-map",
-      mode: "production",
-      entry: entrypoints,
-      cache: false,
-      output: {
-        path: path.join(outFolder, "webpack4"),
-        libraryTarget: "commonjs",
-      },
-      target: "node", // needed for webpack 4 so we can access node api
-      plugins: [
-        sentryWebpackPlugin({
-          ...sentryPluginOptions,
-          release: {
-            name: `${sentryPluginOptions.release.name!}-webpack4`,
-            uploadLegacySourcemaps: `${
-              sentryPluginOptions.release.uploadLegacySourcemaps as string
-            }/webpack4`,
-          },
-        }),
-      ],
-    },
-    (err) => {
-      if (err) {
-        throw err;
-      }
-    }
-  );
-
-  webpack5(
+  webpack(
     {
       devtool: "source-map",
       cache: false,
       entry: entrypoints,
       output: {
-        path: path.join(outFolder, "webpack5"),
+        path: path.join(outFolder, "webpack"),
         library: {
           type: "commonjs",
         },
@@ -137,10 +106,10 @@ export function createCjsBundles(
         sentryWebpackPlugin({
           ...sentryPluginOptions,
           release: {
-            name: `${sentryPluginOptions.release.name!}-webpack5`,
+            name: `${sentryPluginOptions.release.name!}-webpack`,
             uploadLegacySourcemaps: `${
               sentryPluginOptions.release.uploadLegacySourcemaps as string
-            }/webpack5`,
+            }/webpack`,
           },
         }),
       ],

packages/integration-tests/fixtures/after-upload-deletion-promise/after-upload-deletion.test.ts

@@ -2,15 +2,10 @@
 /* eslint-disable jest/expect-expect */
 import path from "path";
 import fs from "fs";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 describe("Deletes files with `filesToDeleteAfterUpload` set to a promise", () => {
-  testIfNodeMajorVersionIsLessThan18("webpack 4 bundle", () => {
-    expect(fs.existsSync(path.join(__dirname, "out", "webpack4", "bundle.js.map"))).toBe(false);
-  });
-
   test("webpack 5 bundle", () => {
-    expect(fs.existsSync(path.join(__dirname, "out", "webpack5", "bundle.js.map"))).toBe(false);
+    expect(fs.existsSync(path.join(__dirname, "out", "webpack", "bundle.js.map"))).toBe(false);
   });
 
   test("esbuild bundle", () => {

packages/integration-tests/fixtures/after-upload-deletion-promise/setup.ts

@@ -3,7 +3,7 @@ import { createCjsBundles } from "../../utils/create-cjs-bundles";
 
 const outputDir = path.resolve(__dirname, "out");
 
-["webpack4", "webpack5", "esbuild", "rollup", "vite"].forEach((bundler) => {
+["webpack", "esbuild", "rollup", "vite"].forEach((bundler) => {
   const fileDeletionGlobPromise = new Promise<string[]>((resolve) => {
     setTimeout(() => {
       resolve([path.join(__dirname, "out", bundler, "bundle.js.map")]);

packages/integration-tests/fixtures/after-upload-deletion/after-upload-deletion.test.ts

@@ -2,15 +2,10 @@
 /* eslint-disable jest/expect-expect */
 import path from "path";
 import fs from "fs";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 describe("Deletes with `filesToDeleteAfterUpload` even without uploading anything", () => {
-  testIfNodeMajorVersionIsLessThan18("webpack 4 bundle", () => {
-    expect(fs.existsSync(path.join(__dirname, "out", "webpack4", "bundle.js.map"))).toBe(false);
-  });
-
-  test("webpack 5 bundle", () => {
-    expect(fs.existsSync(path.join(__dirname, "out", "webpack5", "bundle.js.map"))).toBe(false);
+  test("webpack bundle", () => {
+    expect(fs.existsSync(path.join(__dirname, "out", "webpack", "bundle.js.map"))).toBe(false);
   });
 
   test("esbuild bundle", () => {

packages/integration-tests/fixtures/after-upload-deletion/setup.ts

@@ -3,7 +3,7 @@ import { createCjsBundles } from "../../utils/create-cjs-bundles";
 
 const outputDir = path.resolve(__dirname, "out");
 
-["webpack4", "webpack5", "esbuild", "rollup", "vite"].forEach((bundler) => {
+["webpack", "esbuild", "rollup", "vite"].forEach((bundler) => {
   createCjsBundles(
     {
       bundle: path.resolve(__dirname, "input", "bundle.js"),