-
Notifications
You must be signed in to change notification settings - Fork 54
[@sentry/rollup-plugin] Make rollup an optional peerDependency #910
Copy link
Copy link
Open
Labels
Description
Problem: @sentry/rollup-plugin defines rollup as mandatory peerDependency. However:
Vite 8 is rolldown-based. @sentry/vite-plugin which depends on @sentry/rollup-plugin realistically works in environments where rollup is missing. So having rollup as a mandatory dependency is not correct.
In Yarn, this results in warnings:
Package @sentry/vite-plugin@npm:5.0.0 is requested to provide rollup by its descendants
@sentry/vite-plugin@npm:5.0.0
└─ @sentry/rollup-plugin@npm:5.0.0 [ea3b4] (via >=3.2.0)
✘ Package @sentry/vite-plugin@npm:5.0.0 does not provide rollup.
Solution: add peerDependenciesMeta and mark rollup as optional.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
No status