Skip to content

test: Add additional integration tests#914

Merged
timfish merged 11 commits intomainfrom
timfish/test/more-integration-tests
Apr 15, 2026
Merged

test: Add additional integration tests#914
timfish merged 11 commits intomainfrom
timfish/test/more-integration-tests

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Apr 14, 2026

  • Adds 6 missing integration tests from the old test suite covering edge cases and bundler-specific functionality
  • Adds CJS specific tests
  • readAllFiles was modified to recursively read from subdirectories

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Internal Changes 🔧

  • Add additional integration tests by timfish in #914

🤖 This preview updates automatically when you update the PR.

@timfish timfish force-pushed the timfish/test/more-integration-tests branch from 5c497ff to 1f12cf0 Compare April 14, 2026 15:42
@timfish timfish marked this pull request as ready for review April 14, 2026 15:48
@timfish timfish requested a review from chargome April 14, 2026 15:49
Comment thread packages/integration-tests-next/fixtures/vite4/basic-cjs.config.cjs
cursor[bot]

This comment was marked as outdated.

@timfish timfish requested a review from JPeer264 April 15, 2026 10:22
Copy link
Copy Markdown
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Copy Markdown
Member

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Haven't went into detail to every test though, but went over single ones in detail and they looked good

@timfish timfish merged commit 2d6e401 into main Apr 15, 2026
35 checks passed
@timfish timfish deleted the timfish/test/more-integration-tests branch April 15, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants