Skip to content

Commit 02a15db

Browse files
committed
revert test changes
1 parent 59b43c4 commit 02a15db

4 files changed

Lines changed: 3 additions & 16 deletions

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1128,11 +1128,13 @@ jobs:
11281128
checks: read
11291129
steps:
11301130
- name: Check out current commit
1131+
if: github.ref == 'refs/heads/develop' && contains(needs.*.result, 'failure')
11311132
uses: actions/checkout@v6
11321133
with:
11331134
sparse-checkout: .github
11341135

11351136
- name: Create issues for failed jobs
1137+
if: github.ref == 'refs/heads/develop' && contains(needs.*.result, 'failure')
11361138
uses: actions/github-script@v7
11371139
with:
11381140
script: |

dev-packages/e2e-tests/test-applications/node-express/tests/errors.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForError } from '@sentry-internal/test-utils';
33

4-
// TEMPORARY: Guaranteed failure to verify test name extraction in CI
5-
test('TEMPORARY - should fail to test annotation extraction', () => {
6-
expect(true).toBe(false);
7-
});
8-
94
test('Sends correct error event', async ({ baseURL }) => {
105
const errorEventPromise = waitForError('node-express', event => {
116
return !event.type && event.exception?.values?.[0]?.value === 'This is an exception with id 123';

dev-packages/node-integration-tests/suites/public-api/setTag/with-primitives/test.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,10 @@
1-
import { afterAll, expect, test } from 'vitest';
1+
import { afterAll, test } from 'vitest';
22
import { cleanupChildProcesses, createRunner } from '../../../../utils/runner';
33

44
afterAll(() => {
55
cleanupChildProcesses();
66
});
77

8-
// TEMPORARY: Guaranteed failure to verify test name extraction in CI (Node 18 only)
9-
test.skipIf(!process.version.startsWith('v18'))('TEMPORARY - should fail to test annotation extraction', () => {
10-
expect(true).toBe(false);
11-
});
12-
138
test('should set primitive tags', async () => {
149
await createRunner(__dirname, 'scenario.ts')
1510
.expect({

packages/core/test/lib/session.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@ import type { SessionContext } from '../../src/types-hoist/session';
44
import { timestampInSeconds } from '../../src/utils/time';
55

66
describe('Session', () => {
7-
// TEMPORARY: Guaranteed failure to verify test name extraction in CI (Node 18 only)
8-
it.skipIf(process.env.NODE_VERSION !== '18')('TEMPORARY - should fail to test annotation extraction', () => {
9-
expect(true).toBe(false);
10-
});
11-
127
it('initializes with the proper defaults', () => {
138
const newSession = makeSession();
149
const session = newSession.toJSON();

0 commit comments

Comments
 (0)