remove incremental naming of middlewares

Author: s1gr1d

packages/hono/src/shared/patchAppUse.ts

@@ -10,9 +10,6 @@ import type { Hono, MiddlewareHandler } from 'hono';
 
 const MIDDLEWARE_ORIGIN = 'auto.middleware.hono';
 
-// Module-level counter for anonymous middleware span names
-let MIDDLEWARE_IDX = 0;
-
 /**
  * Patches `app.use` so that every middleware registered through it is automatically
  * wrapped in a Sentry span. Supports both forms: `app.use(...handlers)` and `app.use(path, ...handlers)`.
@@ -22,16 +19,12 @@ export function patchAppUse(app: Hono): void {
     apply(target: typeof app.use, thisArg: typeof app, args: Parameters<typeof app.use>): ReturnType<typeof app.use> {
       const [first, ...rest] = args as [unknown, ...MiddlewareHandler[]];
 
-      const getSpanName = (handler: MiddlewareHandler): string => handler.name || `<anonymous.${MIDDLEWARE_IDX++}>`;
-
       if (typeof first === 'string') {
-        const wrappedHandlers = rest.map(handler => wrapMiddlewareWithSpan(handler, getSpanName(handler)));
+        const wrappedHandlers = rest.map(handler => wrapMiddlewareWithSpan(handler));
         return Reflect.apply(target, thisArg, [first, ...wrappedHandlers]);
       }
 
-      const allHandlers = [first as MiddlewareHandler, ...rest].map(handler =>
-        wrapMiddlewareWithSpan(handler, getSpanName(handler)),
-      );
+      const allHandlers = [first as MiddlewareHandler, ...rest].map(handler => wrapMiddlewareWithSpan(handler));
       return Reflect.apply(target, thisArg, allHandlers);
     },
   });
@@ -42,10 +35,10 @@ export function patchAppUse(app: Hono): void {
  * Uses startInactiveSpan so that all middleware spans are siblings under the request/transaction
  * (onion order: A → B → handler → B → A does not nest B under A in the trace).
  */
-function wrapMiddlewareWithSpan(handler: MiddlewareHandler, spanName: string): MiddlewareHandler {
+function wrapMiddlewareWithSpan(handler: MiddlewareHandler): MiddlewareHandler {
   return async function sentryTracedMiddleware(context, next) {
     const span = startInactiveSpan({
-      name: spanName,
+      name: handler.name || '<anonymous>',
       op: 'middleware.hono',
       onlyIfParent: true,
       attributes: {

packages/hono/test/shared/patchAppUse.test.ts

@@ -77,7 +77,7 @@ describe('patchAppUse (middleware spans)', () => {
 
       expect(startInactiveSpanMock).toHaveBeenCalledTimes(1);
       const name = startInactiveSpanMock.mock.calls[0][0].name;
-      expect(name).toMatch(/^<anonymous\.\d+>$/);
+      expect(name).toMatch('<anonymous>');
     });
   });
 
@@ -112,9 +112,6 @@ describe('patchAppUse (middleware spans)', () => {
   });
 
   it('creates sibling spans for multiple middlewares (onion order, not parent-child)', async () => {
-    vi.resetModules(); // resets the module-level counter variable
-    const { patchAppUse } = await import('../../src/shared/patchAppUse');
-
     const app = new Hono();
     patchAppUse(app);
 
@@ -132,9 +129,9 @@ describe('patchAppUse (middleware spans)', () => {
     const [firstCall, secondCall, thirdCall] = startInactiveSpanMock.mock.calls;
     expect(firstCall[0]).toMatchObject({ op: 'middleware.hono' });
     expect(secondCall[0]).toMatchObject({ op: 'middleware.hono' });
-    expect(firstCall[0].name).toMatch('<anonymous.0>');
+    expect(firstCall[0].name).toMatch('<anonymous>');
     expect(secondCall[0].name).toBe('namedMiddleware');
-    expect(thirdCall[0].name).toBe('<anonymous.1>');
+    expect(thirdCall[0].name).toBe('<anonymous>');
     expect(firstCall[0].name).not.toBe(secondCall[0].name);
   });