Skip to content

Commit 17cb7b4

Browse files
billyvgandreiborza
billyvg
authored and
andreiborza
committed
fix tests
1 parent 803b175 commit 17cb7b4

3 files changed

Lines changed: 14 additions & 183 deletions

File tree

‎dev-packages/browser-integration-tests/suites/replay/captureReplay/test.ts‎

Lines changed: 7 additions & 92 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { expect } from '@playwright/test';
2-
import { SDK_VERSION } from '@sentry/browser';
3-
import { sentryTest, TEST_HOST } from '../../../utils/fixtures';
2+
import { sentryTest } from '../../../utils/fixtures';
3+
import { getExpectedReplayEvent } from '../../../utils/replayEventTemplates';
44
import { getReplayEvent, shouldSkipReplayTest, waitForReplayRequest } from '../../../utils/replayHelpers';
55

66
sentryTest('should capture replays (@sentry/browser export)', async ({ getLocalTestUrl, page }) => {
@@ -20,98 +20,13 @@ sentryTest('should capture replays (@sentry/browser export)', async ({ getLocalT
2020
const replayEvent1 = getReplayEvent(await reqPromise1);
2121

2222
expect(replayEvent0).toBeDefined();
23-
expect(replayEvent0).toEqual({
24-
type: 'replay_event',
25-
timestamp: expect.any(Number),
26-
error_ids: [],
27-
trace_ids: [],
28-
urls: [`${TEST_HOST}/index.html`],
29-
replay_id: expect.stringMatching(/\w{32}/),
30-
replay_start_timestamp: expect.any(Number),
23+
expect(replayEvent0).toEqual(getExpectedReplayEvent({
3124
segment_id: 0,
32-
replay_type: 'session',
33-
event_id: expect.stringMatching(/\w{32}/),
34-
environment: 'production',
35-
contexts: {
36-
culture: {
37-
locale: expect.any(String),
38-
timezone: expect.any(String),
39-
calendar: expect.any(String),
40-
},
41-
},
42-
sdk: {
43-
integrations: expect.arrayContaining([
44-
'InboundFilters',
45-
'FunctionToString',
46-
'BrowserApiErrors',
47-
'Breadcrumbs',
48-
'GlobalHandlers',
49-
'LinkedErrors',
50-
'Dedupe',
51-
'HttpContext',
52-
'BrowserSession',
53-
'Replay',
54-
]),
55-
version: SDK_VERSION,
56-
name: 'sentry.javascript.browser',
57-
settings: {
58-
infer_ip: 'never',
59-
},
60-
},
61-
request: {
62-
url: `${TEST_HOST}/index.html`,
63-
headers: {
64-
'User-Agent': expect.stringContaining(''),
65-
},
66-
},
67-
platform: 'javascript',
68-
});
25+
}));
6926

7027
expect(replayEvent1).toBeDefined();
71-
expect(replayEvent1).toEqual({
72-
type: 'replay_event',
73-
timestamp: expect.any(Number),
74-
error_ids: [],
75-
trace_ids: [],
76-
urls: [],
77-
replay_id: expect.stringMatching(/\w{32}/),
78-
replay_start_timestamp: expect.any(Number),
28+
expect(replayEvent1).toEqual(getExpectedReplayEvent({
7929
segment_id: 1,
80-
replay_type: 'session',
81-
event_id: expect.stringMatching(/\w{32}/),
82-
environment: 'production',
83-
contexts: {
84-
culture: {
85-
locale: expect.any(String),
86-
timezone: expect.any(String),
87-
calendar: expect.any(String),
88-
},
89-
},
90-
sdk: {
91-
integrations: expect.arrayContaining([
92-
'InboundFilters',
93-
'FunctionToString',
94-
'BrowserApiErrors',
95-
'Breadcrumbs',
96-
'GlobalHandlers',
97-
'LinkedErrors',
98-
'Dedupe',
99-
'HttpContext',
100-
'BrowserSession',
101-
'Replay',
102-
]),
103-
version: SDK_VERSION,
104-
name: 'sentry.javascript.browser',
105-
settings: {
106-
infer_ip: 'never',
107-
},
108-
},
109-
request: {
110-
url: `${TEST_HOST}/index.html`,
111-
headers: {
112-
'User-Agent': expect.stringContaining(''),
113-
},
114-
},
115-
platform: 'javascript',
116-
});
30+
urls: [],
31+
}));
11732
});

‎dev-packages/browser-integration-tests/suites/replay/captureReplayFromReplayPackage/test.ts‎

Lines changed: 6 additions & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { expect } from '@playwright/test';
2-
import { SDK_VERSION } from '@sentry/browser';
3-
import { sentryTest, TEST_HOST } from '../../../utils/fixtures';
2+
import { sentryTest } from '../../../utils/fixtures';
3+
import { getExpectedReplayEvent } from '../../../utils/replayEventTemplates';
44
import { getReplayEvent, shouldSkipReplayTest, waitForReplayRequest } from '../../../utils/replayHelpers';
55

66
sentryTest('should capture replays (@sentry-internal/replay export)', async ({ getLocalTestUrl, page }) => {
@@ -20,98 +20,13 @@ sentryTest('should capture replays (@sentry-internal/replay export)', async ({ g
2020
const replayEvent1 = getReplayEvent(await reqPromise1);
2121

2222
expect(replayEvent0).toBeDefined();
23-
expect(replayEvent0).toEqual({
24-
type: 'replay_event',
25-
timestamp: expect.any(Number),
26-
error_ids: [],
27-
trace_ids: [],
28-
urls: [`${TEST_HOST}/index.html`],
29-
replay_id: expect.stringMatching(/\w{32}/),
30-
replay_start_timestamp: expect.any(Number),
23+
expect(replayEvent0).toEqual(getExpectedReplayEvent({
3124
segment_id: 0,
32-
replay_type: 'session',
33-
event_id: expect.stringMatching(/\w{32}/),
34-
environment: 'production',
35-
contexts: {
36-
culture: {
37-
locale: expect.any(String),
38-
timezone: expect.any(String),
39-
calendar: expect.any(String),
40-
},
41-
},
42-
sdk: {
43-
integrations: expect.arrayContaining([
44-
'InboundFilters',
45-
'FunctionToString',
46-
'BrowserApiErrors',
47-
'Breadcrumbs',
48-
'GlobalHandlers',
49-
'LinkedErrors',
50-
'Dedupe',
51-
'HttpContext',
52-
'BrowserSession',
53-
'Replay',
54-
]),
55-
version: SDK_VERSION,
56-
name: 'sentry.javascript.browser',
57-
settings: {
58-
infer_ip: 'never',
59-
},
60-
},
61-
request: {
62-
url: `${TEST_HOST}/index.html`,
63-
headers: {
64-
'User-Agent': expect.stringContaining(''),
65-
},
66-
},
67-
platform: 'javascript',
68-
});
25+
}));
6926

7027
expect(replayEvent1).toBeDefined();
71-
expect(replayEvent1).toEqual({
72-
type: 'replay_event',
73-
timestamp: expect.any(Number),
74-
error_ids: [],
75-
trace_ids: [],
28+
expect(replayEvent1).toEqual(getExpectedReplayEvent({
7629
urls: [],
77-
replay_id: expect.stringMatching(/\w{32}/),
78-
replay_start_timestamp: expect.any(Number),
7930
segment_id: 1,
80-
replay_type: 'session',
81-
event_id: expect.stringMatching(/\w{32}/),
82-
environment: 'production',
83-
contexts: {
84-
culture: {
85-
locale: expect.any(String),
86-
timezone: expect.any(String),
87-
calendar: expect.any(String),
88-
},
89-
},
90-
sdk: {
91-
integrations: expect.arrayContaining([
92-
'InboundFilters',
93-
'FunctionToString',
94-
'BrowserApiErrors',
95-
'Breadcrumbs',
96-
'GlobalHandlers',
97-
'LinkedErrors',
98-
'Dedupe',
99-
'HttpContext',
100-
'BrowserSession',
101-
'Replay',
102-
]),
103-
version: SDK_VERSION,
104-
name: 'sentry.javascript.browser',
105-
settings: {
106-
infer_ip: 'never',
107-
},
108-
},
109-
request: {
110-
url: `${TEST_HOST}/index.html`,
111-
headers: {
112-
'User-Agent': expect.stringContaining(''),
113-
},
114-
},
115-
platform: 'javascript',
116-
});
31+
}));
11732
});

‎dev-packages/browser-integration-tests/utils/replayEventTemplates.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const DEFAULT_REPLAY_EVENT = {
88
timestamp: expect.any(Number),
99
error_ids: [],
1010
trace_ids: [],
11+
traces_by_timestamp: [],
1112
urls: [expect.stringContaining('/index.html')],
1213
replay_id: expect.stringMatching(/\w{32}/),
1314
replay_start_timestamp: expect.any(Number),

0 commit comments

Comments
 (0)