fixup! test(cloudflare): Unflake integration test

Author: JPeer264

dev-packages/cloudflare-integration-tests/runner.ts

@@ -50,6 +50,12 @@ type StartResult = {
     path: string,
     options?: { headers?: Record<string, string>; data?: BodyInit; expectError?: boolean },
   ): Promise<T | undefined>;
+  makeRequestAndWaitForEnvelope<T>(
+    method: 'get' | 'post',
+    path: string,
+    expected: Expected | Expected[],
+    options?: { headers?: Record<string, string>; data?: BodyInit; expectError?: boolean },
+  ): Promise<T | undefined>;
 };
 
 /** Creates a test runner */
@@ -108,6 +114,7 @@ export function createRunner(...paths: string[]) {
       const expectedEnvelopeCount = expectedEnvelopes.length;
 
       let envelopeCount = 0;
+      const envelopeWaiters: { expected: Expected; resolve: () => void; reject: (e: unknown) => void }[] = [];
       const { resolve: setWorkerPort, promise: workerPortPromise } = deferredPromise<number>();
       let child: ReturnType<typeof spawn> | undefined;
       let childSubWorker: ReturnType<typeof spawn> | undefined;
@@ -120,6 +127,12 @@ export function createRunner(...paths: string[]) {
         }
       }
 
+      function waitForEnvelope(expected: Expected): Promise<void> {
+        return new Promise((resolveWaiter, rejectWaiter) => {
+          envelopeWaiters.push({ expected, resolve: resolveWaiter, reject: rejectWaiter });
+        });
+      }
+
       function assertEnvelopeMatches(expected: Expected, envelope: Envelope): void {
         if (typeof expected === 'function') {
           expected(envelope);
@@ -137,6 +150,18 @@ export function createRunner(...paths: string[]) {
           return;
         }
 
+        // Check per-request waiters first (FIFO order)
+        if (envelopeWaiters.length > 0) {
+          const waiter = envelopeWaiters.shift()!;
+          try {
+            assertEnvelopeMatches(waiter.expected, envelope);
+            waiter.resolve();
+          } catch (e) {
+            waiter.reject(e);
+          }
+          return;
+        }
+
         try {
           if (unordered) {
             // find any matching expected envelope
@@ -308,6 +333,18 @@ export function createRunner(...paths: string[]) {
             return;
           }
         },
+        makeRequestAndWaitForEnvelope: async function <T>(
+          method: 'get' | 'post',
+          path: string,
+          expected: Expected | Expected[],
+          options: { headers?: Record<string, string>; data?: BodyInit; expectError?: boolean } = {},
+        ): Promise<T | undefined> {
+          const expectations = Array.isArray(expected) ? expected : [expected];
+          const envelopePromises = expectations.map(e => waitForEnvelope(e));
+          const result = await this.makeRequest<T>(method, path, options);
+          await Promise.all(envelopePromises);
+          return result;
+        },
       };
     },
   };

dev-packages/cloudflare-integration-tests/suites/tracing/durableobject-spans/test.ts

@@ -25,15 +25,13 @@ it.skip('sends child spans on repeated Durable Object calls', async ({ signal })
 
     // All 5 child spans should be present
     expect(transactionEvent.spans).toHaveLength(5);
-    expect(transactionEvent.spans).toEqual(
-      expect.arrayContaining([
-        expect.objectContaining({ description: 'task-1', op: 'task' }),
-        expect.objectContaining({ description: 'task-2', op: 'task' }),
-        expect.objectContaining({ description: 'task-3', op: 'task' }),
-        expect.objectContaining({ description: 'task-4', op: 'task' }),
-        expect.objectContaining({ description: 'task-5', op: 'task' }),
-      ]),
-    );
+    expect(transactionEvent.spans).toEqual([
+      expect.objectContaining({ description: 'task-1', op: 'task' }),
+      expect.objectContaining({ description: 'task-2', op: 'task' }),
+      expect.objectContaining({ description: 'task-3', op: 'task' }),
+      expect.objectContaining({ description: 'task-4', op: 'task' }),
+      expect.objectContaining({ description: 'task-5', op: 'task' }),
+    ]);
 
     // All child spans share the root trace_id
     const rootTraceId = transactionEvent.contexts?.trace?.trace_id;
@@ -43,23 +41,12 @@ it.skip('sends child spans on repeated Durable Object calls', async ({ signal })
     }
   }
 
-  // Expect 5 transaction envelopes — one per call.
-  const runner = createRunner(__dirname).expectN(5, assertDoWorkEnvelope).start(signal);
-
-  // Small delay between requests to allow waitUntil to process in wrangler dev.
-  // This is needed because wrangler dev may not guarantee waitUntil completion
-  // the same way production Cloudflare does. Without this delay, the last
-  // envelope's HTTP request may not complete before the test moves on.
-  const delay = () => new Promise(resolve => setTimeout(resolve, 50));
+  const runner = createRunner(__dirname).start(signal);
 
-  await runner.makeRequest('get', '/');
-  await delay();
-  await runner.makeRequest('get', '/');
-  await delay();
-  await runner.makeRequest('get', '/');
-  await delay();
-  await runner.makeRequest('get', '/');
-  await delay();
-  await runner.makeRequest('get', '/');
-  await runner.completed();
+  // Each request waits for its envelope to be received and validated before proceeding.
+  await runner.makeRequestAndWaitForEnvelope('get', '/', assertDoWorkEnvelope);
+  await runner.makeRequestAndWaitForEnvelope('get', '/', assertDoWorkEnvelope);
+  await runner.makeRequestAndWaitForEnvelope('get', '/', assertDoWorkEnvelope);
+  await runner.makeRequestAndWaitForEnvelope('get', '/', assertDoWorkEnvelope);
+  await runner.makeRequestAndWaitForEnvelope('get', '/', assertDoWorkEnvelope);
 });