even more cleanup

Author: Lms24

packages/node-core/src/utils/outgoingFetchRequest.ts

@@ -97,7 +97,7 @@ function stringToArrayHeaders(requestHeaders: string): string[] {
       }
       const key = header.slice(0, colonIndex).trim();
       const value = header.slice(colonIndex + 1).trim();
-      if (key && value) {
+      if (key) {
         headers.push(key, value);
       }
     } catch {}
@@ -107,9 +107,13 @@ function stringToArrayHeaders(requestHeaders: string): string[] {
 
 function arrayToStringHeaders(headers: string[]): string {
   const headerPairs: string[] = [];
-  for (let i = 0; i < headers.length; i += 2) {
-    headerPairs.push(`${headers[i]}: ${headers[i + 1]}`);
-  }
+
+  try {
+    for (let i = 0; i < headers.length; i += 2) {
+      headerPairs.push(`${headers[i]}: ${headers[i + 1]}`);
+    }
+  } catch {}
+
   if (!headerPairs.length) {
     return '';
   }

packages/node-core/src/utils/outgoingHttpRequest.ts

@@ -66,7 +66,7 @@ export function addTracePropagationHeadersToOutgoingRequest(
 
   const { 'sentry-trace': sentryTrace, baggage, traceparent } = headersToAdd;
 
-  const hasExistingSentryTraceHeader = request.getHeader('sentry-trace');
+  const hasExistingSentryTraceHeader = !!request.getHeader('sentry-trace');
 
   if (sentryTrace && !hasExistingSentryTraceHeader) {
     try {