Commit 406ce22
fix(deno): Clear pre-existing OTel global before registering TracerProvider (#19723)
## Summary
- Calls `trace.disable()` before `trace.setGlobalTracerProvider()` in
`@sentry/deno`'s OTel tracer setup
- This fixes silent registration failure when Supabase Edge Runtime (or
Deno's native OTel) pre-registers a `TracerProvider` on the
`@opentelemetry/api` global (`Symbol.for('opentelemetry.js.api.1')`)
- Without this fix, **OTel-instrumented spans** (e.g. `gen_ai.*` from AI
SDK, or any library using `@opentelemetry/api`) never reach Sentry
because Sentry's `TracerProvider` fails to register as the global.
Sentry's own `startSpan()` API is unaffected since it bypasses the OTel
global.
## Context
Supabase Edge Runtime (Deno 2.1.4+) registers its own `TracerProvider`
before user code runs. The OTel API's `trace.setGlobalTracerProvider()`
is a no-op if a provider is already registered (it only logs a diag
warning), so Sentry's tracer silently gets ignored.
**What works without the fix:** `Sentry.startSpan()` — goes through
Sentry's internal pipeline, not the OTel global.
**What breaks without the fix:** Any spans created via
`@opentelemetry/api` (AI SDK's `gen_ai.*` spans, HTTP instrumentations,
etc.) — these hit the pre-existing Supabase provider instead of
Sentry's.
Calling `trace.disable()` clears the global, allowing
`trace.setGlobalTracerProvider()` to succeed. This matches the pattern
already used in `cleanupOtel()` in the test file and is safe because:
1. It only runs once during `Sentry.init()`
2. Any pre-existing provider is immediately replaced by Sentry's
3. It's gated behind `skipOpenTelemetrySetup` so users with custom OTel
setups can opt out
4. The Cloudflare package was investigated and doesn't have the same
issue
## Test plan
- [x] Updated `should override pre-existing OTel provider with Sentry
provider` unit test — simulates a pre-existing provider and verifies
Sentry overrides it
- [x] Updated `should override native Deno OpenTelemetry when enabled`
unit test — verifies Sentry captures spans even when `OTEL_DENO=true`
- [x] **E2E test app**
(`dev-packages/e2e-tests/test-applications/deno/`) — Deno server with
pre-existing OTel provider, 5 tests:
- Error capture (`Sentry.captureException`)
- `Sentry.startSpan` transaction
- OTel `tracer.startSpan` despite pre-existing provider (core regression
test)
- OTel `tracer.startActiveSpan` (AI SDK pattern)
- Sentry + OTel interop (OTel child inside Sentry parent)
- [x] Verified manually with Supabase Edge Function + AI SDK:
`Sentry.startSpan()` spans appeared in Sentry both before and after the
fix, but `gen_ai.*` OTel spans only appeared after the fix
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Closes #19724
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>1 parent 41fc707 commit 406ce22
File tree
11 files changed
+280
-34
lines changed- .github/workflows
- dev-packages/e2e-tests/test-applications/deno
- src
- tests
- packages/deno
- src/opentelemetry
- test
11 files changed
+280
-34
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
969 | 969 | | |
970 | 970 | | |
971 | 971 | | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
972 | 977 | | |
973 | 978 | | |
974 | 979 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
Lines changed: 23 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
Lines changed: 90 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
| |||
0 commit comments