Skip to content

Commit 40d8524

Browse files
mydeaclaude
andcommitted
chore(ci): Remove node-overhead GitHub Action
The node overhead check was too flaky to be reliable and was mostly ignored in practice. Remove the entire `node-overhead-gh-action` dev-package and its CI job. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 4f0c089 commit 40d8524

File tree

16 files changed

+0
-944
lines changed

16 files changed

+0
-944
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,6 @@ jobs:
152152
changed_node:
153153
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
154154
'@sentry/node') }}
155-
changed_node_overhead_action:
156-
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
157-
'@sentry-internal/node-overhead-gh-action') }}
158155
changed_deno:
159156
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
160157
'@sentry/deno') }}
@@ -208,37 +205,6 @@ jobs:
208205
# Only run comparison against develop if this is a PR
209206
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}
210207

211-
job_node_overhead_check:
212-
name: Node Overhead Check
213-
needs: [job_get_metadata, job_build]
214-
timeout-minutes: 15
215-
runs-on: ubuntu-24.04
216-
if:
217-
(needs.job_build.outputs.changed_node == 'true' && github.event_name == 'pull_request') ||
218-
(needs.job_build.outputs.changed_node_overhead_action == 'true' && github.event_name == 'pull_request') ||
219-
needs.job_get_metadata.outputs.is_base_branch == 'true' || needs.job_get_metadata.outputs.is_release == 'true'
220-
steps:
221-
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
222-
uses: actions/checkout@v6
223-
with:
224-
ref: ${{ env.HEAD_COMMIT }}
225-
- name: Set up Node
226-
uses: actions/setup-node@v6
227-
with:
228-
node-version-file: 'package.json'
229-
- name: Restore caches
230-
uses: ./.github/actions/restore-cache
231-
with:
232-
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
233-
- name: Check node overhead
234-
uses: ./dev-packages/node-overhead-gh-action
235-
env:
236-
DEBUG: '1'
237-
with:
238-
github_token: ${{ secrets.GITHUB_TOKEN }}
239-
# Only run comparison against develop if this is a PR
240-
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}
241-
242208
job_lint:
243209
name: Lint
244210
# Even though the linter only checks source code, not built code, it needs the built code in order check that all

dev-packages/node-overhead-gh-action/.oxlintrc.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

dev-packages/node-overhead-gh-action/README.md

Lines changed: 0 additions & 3 deletions
This file was deleted.

dev-packages/node-overhead-gh-action/action.yml

Lines changed: 0 additions & 17 deletions
This file was deleted.

dev-packages/node-overhead-gh-action/db/init/init.sql

Lines changed: 0 additions & 25 deletions
This file was deleted.

dev-packages/node-overhead-gh-action/docker-compose.yml

Lines changed: 0 additions & 12 deletions
This file was deleted.

dev-packages/node-overhead-gh-action/index.mjs

Lines changed: 0 additions & 236 deletions
This file was deleted.

0 commit comments

Comments
 (0)