Skip to content

Commit 45d7b06

Browse files
mydeaclaude
andauthored
chore(ci): Remove codecov steps from jobs that produce no coverage/JUnit data (#20244)
## Summary - Remove `getsentry/codecov-action` from CI jobs that don't produce coverage or JUnit XML files, eliminating noisy warnings in every CI run - Disable coverage upload for Playwright browser integration tests that only produce JUnit XML ### Jobs cleaned up: | Job | Issue | Fix | |-----|-------|-----| | Node Integration Tests | Coverage disabled in vitest config, custom reporters without JUnit | Removed codecov step entirely | | Node-Core Integration Tests | Same as above | Removed codecov step entirely | | E2E Tests | Uses ts-node/Playwright, not vitest | Removed codecov step entirely | | Remix Tests | Custom vitest config without coverage/JUnit | Removed codecov step entirely | | Playwright Browser Tests | No coverage files (Playwright, not vitest) | Added `enable-coverage: false` | | PW Loader Tests | Same as above | Added `enable-coverage: false` | ### Warnings eliminated: - `No coverage files found` (from integration tests, E2E, Remix, Playwright jobs) - `No JUnit XML files found matching pattern: dev-packages/{node,node-core}-integration-tests/**/*.junit.xml` - `No JUnit XML files found matching pattern: dev-packages/e2e-tests/**/*.junit.xml` - `Please ensure your test framework is generating JUnit XML output` - `Supported formats: clover, cobertura, jacoco, lcov, istanbul, go, codecov` ### Not addressed (upstream issue): - `Entity expansion limit exceeded: 100X > 1000` on vitest JUnit XML files — this is a parser limitation in `getsentry/codecov-action` that affects large test suites (browser, core, node, nextjs, etc.) ## Test plan - [ ] CI runs cleanly without the removed warnings - [ ] Coverage still uploads correctly for Browser Unit Tests and Node Unit Tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 4f0c089 commit 45d7b06

File tree

1 file changed

+2
-37
lines changed

1 file changed

+2
-37
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,7 @@ jobs:
605605
with:
606606
token: ${{ secrets.GITHUB_TOKEN }}
607607
directory: dev-packages/browser-integration-tests
608+
enable-coverage: false
608609
name:
609610
browser-playwright-${{ matrix.bundle }}-${{ matrix.project }}${{ matrix.shard && format('-{0}',
610611
matrix.shard) || '' }}
@@ -669,6 +670,7 @@ jobs:
669670
with:
670671
token: ${{ secrets.GITHUB_TOKEN }}
671672
directory: dev-packages/browser-integration-tests
673+
enable-coverage: false
672674
name: browser-loader-${{ matrix.bundle }}
673675

674676
job_check_for_faulty_dts:
@@ -737,15 +739,6 @@ jobs:
737739
working-directory: dev-packages/node-integration-tests
738740
run: yarn test
739741

740-
- name: Parse and Upload Coverage
741-
if: cancelled() == false
742-
continue-on-error: true
743-
uses: getsentry/codecov-action@main
744-
with:
745-
token: ${{ secrets.GITHUB_TOKEN }}
746-
directory: dev-packages/node-integration-tests
747-
name: node-integration-${{ matrix.node }}${{ matrix.typescript && format('-ts{0}', matrix.typescript) || '' }}
748-
749742
job_node_core_integration_tests:
750743
name:
751744
Node (${{ matrix.node }})${{ (matrix.typescript && format(' (TS {0})', matrix.typescript)) || '' }} Node-Core
@@ -787,16 +780,6 @@ jobs:
787780
working-directory: dev-packages/node-core-integration-tests
788781
run: yarn test
789782

790-
- name: Parse and Upload Coverage
791-
if: cancelled() == false
792-
continue-on-error: true
793-
uses: getsentry/codecov-action@main
794-
with:
795-
token: ${{ secrets.GITHUB_TOKEN }}
796-
directory: dev-packages/node-core-integration-tests
797-
name:
798-
node-core-integration-${{ matrix.node }}${{ matrix.typescript && format('-ts{0}', matrix.typescript) || ''}}
799-
800783
job_cloudflare_integration_tests:
801784
name: Cloudflare Integration Tests
802785
needs: [job_get_metadata, job_build]
@@ -856,15 +839,6 @@ jobs:
856839
cd packages/remix
857840
yarn test:integration:ci
858841
859-
- name: Parse and Upload Coverage
860-
if: cancelled() == false
861-
continue-on-error: true
862-
uses: getsentry/codecov-action@main
863-
with:
864-
directory: packages/remix
865-
token: ${{ secrets.GITHUB_TOKEN }}
866-
name: ${{ matrix.node }}
867-
868842
job_e2e_prepare:
869843
name: Prepare E2E tests
870844
# We want to run this if:
@@ -1053,15 +1027,6 @@ jobs:
10531027
retention-days: 7
10541028
if-no-files-found: ignore
10551029

1056-
- name: Parse and Upload Coverage
1057-
if: cancelled() == false
1058-
continue-on-error: true
1059-
uses: getsentry/codecov-action@main
1060-
with:
1061-
directory: dev-packages/e2e-tests
1062-
token: ${{ secrets.GITHUB_TOKEN }}
1063-
name: e2e-${{ matrix.test-application }}
1064-
10651030
# - We skip optional tests on release branches
10661031
job_optional_e2e_tests:
10671032
name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)

0 commit comments

Comments
 (0)