remove unnecessary ignoreSpans check in otel trace.ts files.

Author: Lms24

packages/opentelemetry/src/trace.ts

@@ -23,8 +23,6 @@ import {
   hasSpansEnabled,
   SDK_VERSION,
   SEMANTIC_ATTRIBUTE_SENTRY_OP,
-  SentryNonRecordingSpan,
-  shouldIgnoreSpan,
   spanToJSON,
   spanToTraceContext,
 } from '@sentry/core';
@@ -49,16 +47,6 @@ function _startSpan<T>(options: OpenTelemetrySpanContext, callback: (span: Span)
   const wrapper = getActiveSpanWrapper<T>(customParentSpan);
 
   return wrapper(() => {
-    const client = getClient();
-    const ignoreSpans = client?.getOptions().ignoreSpans;
-    if (ignoreSpans?.length) {
-      const op = options.op || options.attributes?.[SEMANTIC_ATTRIBUTE_SENTRY_OP];
-      if (shouldIgnoreSpan({ description: name, op }, ignoreSpans)) {
-        client?.recordDroppedEvent('ignored', 'span');
-        return callback(new SentryNonRecordingSpan());
-      }
-    }
-
     const activeCtx = getContext(options.scope, options.forceTransaction);
     const shouldSkipSpan = options.onlyIfParent && !trace.getSpan(activeCtx);
     const ctx = shouldSkipSpan ? suppressTracing(activeCtx) : activeCtx;
@@ -162,16 +150,6 @@ export function startInactiveSpan(options: OpenTelemetrySpanContext): Span {
   const wrapper = getActiveSpanWrapper<Span>(customParentSpan);
 
   return wrapper(() => {
-    const client = getClient();
-    const ignoreSpans = client?.getOptions().ignoreSpans;
-    if (ignoreSpans?.length) {
-      const op = options.op || options.attributes?.[SEMANTIC_ATTRIBUTE_SENTRY_OP];
-      if (shouldIgnoreSpan({ description: name, op }, ignoreSpans)) {
-        client?.recordDroppedEvent('ignored', 'span');
-        return new SentryNonRecordingSpan();
-      }
-    }
-
     const activeCtx = getContext(options.scope, options.forceTransaction);
     const shouldSkipSpan = options.onlyIfParent && !trace.getSpan(activeCtx);
     let ctx = shouldSkipSpan ? suppressTracing(activeCtx) : activeCtx;

packages/opentelemetry/test/trace.test.ts

@@ -2190,55 +2190,6 @@ function getSpanName(span: AbstractSpan): string | undefined {
   return spanHasName(span) ? span.name : undefined;
 }
 
-describe('trace (ignoreSpans)', () => {
-  afterEach(async () => {
-    await cleanupOtel();
-  });
-
-  it('returns a non-recording span for an ignored span via startSpan', () => {
-    mockSdkInit({ tracesSampleRate: 1, ignoreSpans: ['ignored-span'] });
-
-    startSpan({ name: 'root' }, () => {
-      startSpan({ name: 'ignored-span' }, span => {
-        expect(spanIsSampled(span)).toBe(false);
-        expect(span.isRecording()).toBe(false);
-      });
-    });
-  });
-
-  it('children of ignored spans parent to grandparent via startSpan', () => {
-    mockSdkInit({ tracesSampleRate: 1, ignoreSpans: ['ignored-span'] });
-
-    startSpan({ name: 'root' }, rootSpan => {
-      const rootSpanId = rootSpan.spanContext().spanId;
-
-      startSpan({ name: 'ignored-span' }, () => {
-        startSpan({ name: 'grandchild' }, grandchildSpan => {
-          const parentId = getSpanParentSpanId(grandchildSpan);
-          expect(parentId).toBe(rootSpanId);
-        });
-      });
-    });
-  });
-
-  it('returns a non-recording span for an ignored span via startInactiveSpan', () => {
-    mockSdkInit({ tracesSampleRate: 1, ignoreSpans: ['ignored-span'] });
-
-    const span = startInactiveSpan({ name: 'ignored-span' });
-    expect(spanIsSampled(span)).toBe(false);
-    expect(span.isRecording()).toBe(false);
-  });
-
-  it('does not ignore non-matching spans', () => {
-    mockSdkInit({ tracesSampleRate: 1, ignoreSpans: ['ignored-span'] });
-
-    startSpan({ name: 'normal-span' }, span => {
-      expect(spanIsSampled(span)).toBe(true);
-      expect(span.isRecording()).toBe(true);
-    });
-  });
-});
-
 function getSpanEndTime(span: AbstractSpan): [number, number] | undefined {
   return (span as ReadableSpan).endTime;
 }