Skip to content

Commit 4cccd63

Browse files
committed
fix e2e tests
1 parent b2caccb commit 4cccd63

2 files changed

Lines changed: 7 additions & 15 deletions

File tree

dev-packages/e2e-tests/lib/pnpmOverrides.ts

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,28 +14,14 @@ export async function addPnpmOverrides(tmpDirPath: string, packedDirPath: string
1414
const packageJsonPath = path.join(tmpDirPath, 'package.json');
1515
const packageJson = JSON.parse(await readFile(packageJsonPath, 'utf8')) as {
1616
pnpm?: { overrides?: Record<string, string> };
17-
dependencies?: Record<string, string>;
18-
devDependencies?: Record<string, string>;
1917
};
2018

2119
const overrides: Record<string, string> = {};
2220

2321
const packageNames = getPublishedSentryTarballPackageNames();
2422

25-
const dependencies = packageJson.dependencies ?? {};
26-
const devDependencies = packageJson.devDependencies ?? {};
27-
28-
// Override anything that is not a dependency of the application itself,
29-
// to ensure we do not accidentally overwrite weird/custom things
30-
const deps = {
31-
...dependencies,
32-
...devDependencies,
33-
};
34-
3523
for (const packageName of packageNames) {
36-
if (!deps[packageName]) {
37-
overrides[packageName] = `file:${packedDirPath}/${packedSymlinkFilename(packageName)}`;
38-
}
24+
overrides[packageName] = `file:${packedDirPath}/${packedSymlinkFilename(packageName)}`;
3925
}
4026

4127
packageJson.pnpm = {

dev-packages/e2e-tests/test-applications/aws-serverless/package.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,12 @@
2525
"volta": {
2626
"extends": "../../package.json"
2727
},
28+
"//": "We need to override this here again to ensure this is not overwritten by the test runner",
29+
"pnpm": {
30+
"overrides": {
31+
"@sentry/aws-serverless": "link:../../../../packages/aws-serverless/build/aws/dist-serverless/"
32+
}
33+
},
2834
"sentryTest": {
2935
"variants": [
3036
{

0 commit comments

Comments
 (0)